Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of FSimGate has incorrect phase convention #6297

Closed
kevinsung opened this issue Sep 21, 2023 · 4 comments
Closed

Documentation of FSimGate has incorrect phase convention #6297

kevinsung opened this issue Sep 21, 2023 · 4 comments
Assignees
Labels
kind/bug-report Something doesn't seem to work. kind/docs Documentation related problems, ideas, requests status/stale This has been closed due to inactivity for an extended period of time.

Comments

@kevinsung
Copy link
Collaborator

Description of the issue
https://quantumai.google/reference/python/cirq/FSimGate

image

The definition of c should have a negative sign in the exponent.

import cirq
import numpy as np

np.round(cirq.unitary(cirq.FSimGate(theta=0, phi=np.pi / 2)))
array([[1.+0.j, 0.+0.j, 0.+0.j, 0.+0.j],
       [0.+0.j, 1.+0.j, 0.-0.j, 0.+0.j],
       [0.+0.j, 0.-0.j, 1.+0.j, 0.+0.j],
       [0.+0.j, 0.+0.j, 0.+0.j, 0.-1.j]])
@kevinsung kevinsung added kind/bug-report Something doesn't seem to work. kind/docs Documentation related problems, ideas, requests labels Sep 21, 2023
@maffoo
Copy link
Contributor

maffoo commented Sep 21, 2023

This was fixed recently but the doc site may not have been updated yet: #6288

@pavoljuhas
Copy link
Collaborator

TODO - check if this is updated at the nightly build and then close if so.

@pavoljuhas pavoljuhas self-assigned this Oct 11, 2023
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days

Copy link

Issue closed due to inactivity.

@mhucka mhucka added T status/stale This has been closed due to inactivity for an extended period of time. triage/stale and removed triage/stale labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-report Something doesn't seem to work. kind/docs Documentation related problems, ideas, requests status/stale This has been closed due to inactivity for an extended period of time.
Projects
None yet
Development

No branches or pull requests

4 participants