Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider a unique definition for Wavefunction #63

Open
rmlarose opened this issue Jan 5, 2021 · 2 comments
Open

Consider a unique definition for Wavefunction #63

rmlarose opened this issue Jan 5, 2021 · 2 comments

Comments

@rmlarose
Copy link
Collaborator

rmlarose commented Jan 5, 2021

Wavefunction is currently multiply defined, once as the class and once as a getter function for the class. This caused a few issues with mypy, and while they are easily resolved by importing the correct Wavefunction, there is a chance for confusion. Perhaps refactor the function to get_wavefunction or a similar name?
@wjhuggins
Copy link
Contributor

This causes additional problems with Pylance in VSCode. It really would be a nice change even if it's annoying to break people's code.

@wjhuggins
Copy link
Contributor

Would a PR that does this be approved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmlarose @wjhuggins