notebook test import #116
Closed
notebook test import #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This doesn't appear to work on a fresh remote google colab on colab.sandbox.google.com. Looking closer it appears that the unittest_data isn't available on the pypi.org website: https://pypi.org/project/fqe/#files (inside the 0.2.0.tar.gz file the folder isn't there).
So I think we may need a different approach.
|
Okay. I will either include the folder in the manifest or move the folder into the module. Adding to manifest will include something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example hack to let the notebook run. Because tests are moved outside the package module and we don't have a config file like OpenFermion this hack is necessary. @MichaelBroughton what do you suggest. For almost all OpenFermion packages we need to ship test data. Previously, in openfermion, we moved test data out of the module, but we relied on it so much for examples we ended up moving it back. Should we consider the same here? Is there a standard way of doing this?