Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build broken #526

Open
95-martin-orion opened this issue Apr 11, 2022 · 3 comments
Open

Windows build broken #526

95-martin-orion opened this issue Apr 11, 2022 · 3 comments
Assignees

Comments

@95-martin-orion
Copy link
Collaborator

The Windows builds on Kokoro are breaking with a number of disconcerting messages:

> bazel test --test_output=errors --copt=/D_USE_MATH_DEFINES tests:all
ERROR: C:/tools/msys64/home/kbuilder/_bazel_kbuilder/yic25m7j/external/local_config_cc/BUILD:274:24:
unterminated string literal at eol
{...}
Target '//lib:vectorspace' depends on toolchain '@local_config_cc//:cc-compiler-x64_windows',
which cannot be found

These do not appear in previous passing runs. This failure is blocking submit (#521).

@95-martin-orion 95-martin-orion self-assigned this Apr 11, 2022
@95-martin-orion
Copy link
Collaborator Author

This appears to be the result of changes in the Tensorflow toolchain location - hoping to have a fix out later today.

@95-martin-orion
Copy link
Collaborator Author

This fix has been delayed due to long-standing inconsistencies between the qsim and Tensorflow build processes, which we're now trying to reconcile. Existing builds of qsim (installed with pip install qsimcirq) are unaffected by this, but open PRs will continue to be blocked for a while longer. Thank you for your patience.

@95-martin-orion
Copy link
Collaborator Author

In the absence of a quick solution for this, we have opted to disable the qsim Windows build to unblock other PRs. We will continue working with the TFQ team to resolve the issue, but for the time being Windows users are advised to install the most recent release prior to the issue (qsimcirq==0.12.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant