Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce helper method "isRHBQ()" to differentiate between upstream and RH build #1215

Closed
rsvoboda opened this issue Jul 22, 2024 · 2 comments · Fixed by #1294
Closed

Introduce helper method "isRHBQ()" to differentiate between upstream and RH build #1215

rsvoboda opened this issue Jul 22, 2024 · 2 comments · Fixed by #1294
Assignees
@TimonCzech
Labels
good first issue Good for newcomers

Comments

@rsvoboda
Copy link
Member

Introduce helper method "isRHBQ()" to differentiate between upstream and RH build

In https://github.com/quarkus-qe/quarkus-test-suite I noticed code like QuarkusProperties.getVersion().contains("redhat") occurring in several places.

We should have central helper method in FW.
@rsvoboda rsvoboda added the good first issue Good for newcomers label Jul 22, 2024
@michalvavrik michalvavrik mentioned this issue Sep 3, 2024
Merged
9 tasks
@TimonCzech
Copy link

Can I take it?

@michalvavrik
Copy link
Contributor

Can I take it?

yep

@TimonCzech TimonCzech mentioned this issue Sep 9, 2024
Merged
11 tasks
@jedla97 jedla97 linked a pull request Sep 9, 2024 that will close this issue
Added isRHBQ method to check if the version contain string redhat #1294
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimonCzech TimonCzech

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added isRHBQ method to check if the version contain string redhat TimonCzech/quarkus-test-framework
3 participants
@rsvoboda @michalvavrik @TimonCzech