Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible data race during deletion of logs #612

Open
fedinskiy opened this issue Nov 3, 2022 · 0 comments
Open

Possible data race during deletion of logs #612

fedinskiy opened this issue Nov 3, 2022 · 0 comments
Labels
bug Something isn't working priority/moderate higher priority than low but lower then high

Comments

@fedinskiy
Copy link
Contributor

When running tests without ts.global.delete.folder.on.exit=false option I sometimes see a warning "Exception when reading file log" and after some debugging, it turns out, that this is due to attempt to read log file of Quarkus application after it was removed by our framework.

I noticed this behavior while working on Infinispan tests where Inifispan container was started by podman, probably this added some additional latency.

Reproducer:

  1. git clone git@github.com:fedinskiy/quarkus-test-suite.git -b reproducer/infinispan && cd quarkus-test-suite
  2. mvn clean verify -pl messaging/infinispan-grpc-kafka/ -Dit.test=InfinispanKafkaIT # there is a warning in logs . Debugging shows, that underlying issue is java.nio.file.NoSuchFileException: target/InfinispanKafkaIT/app/out.log
  3. mvn clean verify -pl messaging/infinispan-grpc-kafka/ -Dit.test=InfinispanKafkaIT -Dts.global.delete.folder.on.exit=false # no warning

Warning originates from files quarkus-test-core/src/main/java/io/quarkus/test/logging/FileServiceLoggingHandler.java, but there is similar code in quarkus-test-core/src/main/java/io/quarkus/test/logging/FileLoggingHandler.java

I am not sure, whether this causes some tests to fail, but I cannot rule this possibility out either.
In addition, it would be nice to add information about file and exception to the warning.

@michalvavrik michalvavrik added bug Something isn't working priority/moderate higher priority than low but lower then high labels Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/moderate higher priority than low but lower then high
Projects
None yet
Development

No branches or pull requests

2 participants