Merge pull request #392 from gsmet/missing-override

Add missing @OverRide annotations
quarkusio · Dec 26, 2018 · 576b6af · 576b6af
2 parents 8638731 + 4378401
commit 576b6af
Show file tree

Hide file tree

Showing 45 changed files with 140 additions and 0 deletions.
diff --git a/builder/src/main/java/org/jboss/builder/ConsumeFlags.java b/builder/src/main/java/org/jboss/builder/ConsumeFlags.java
@@ -24,22 +24,27 @@
  */
 public final class ConsumeFlags extends Flags<ConsumeFlag, ConsumeFlags> {
 
+    @Override
     protected ConsumeFlags value(final int bits) {
         return values[bits & enumValues.length - 1];
     }
 
+    @Override
     protected ConsumeFlags this_() {
         return this;
     }
 
+    @Override
     protected ConsumeFlag itemOf(final int index) {
         return enumValues[index];
     }
 
+    @Override
     protected ConsumeFlag castItemOrNull(final Object obj) {
         return obj instanceof ConsumeFlag ? (ConsumeFlag) obj : null;
     }
 
+    @Override
     protected ConsumeFlags castThis(final Object obj) {
         return (ConsumeFlags) obj;
     }

diff --git a/builder/src/main/java/org/jboss/builder/FinalStep.java b/builder/src/main/java/org/jboss/builder/FinalStep.java
@@ -19,6 +19,7 @@
 /**
  */
 final class FinalStep implements BuildStep {
+    @Override
     public void execute(final BuildContext context) {
 
     }

diff --git a/builder/src/main/java/org/jboss/builder/ItemId.java b/builder/src/main/java/org/jboss/builder/ItemId.java
@@ -44,6 +44,7 @@ boolean isMulti() {
         return MultiBuildItem.class.isAssignableFrom(itemType) || NamedMultiBuildItem.class.isAssignableFrom(itemType);
     }
 
+    @Override
     public boolean equals(Object obj) {
         return obj instanceof ItemId && equals((ItemId) obj);
     }
@@ -52,10 +53,12 @@ boolean equals(ItemId obj) {
         return this == obj || obj != null && itemType == obj.itemType && Objects.equals(name, obj.name);
     }
 
+    @Override
     public int hashCode() {
         return Objects.hashCode(name) * 31 + Objects.hashCode(itemType);
     }
 
+    @Override
     public String toString() {
         final Object name = this.name;
         final Class<? extends BuildItem> itemType = this.itemType;

diff --git a/builder/src/main/java/org/jboss/builder/ProduceFlags.java b/builder/src/main/java/org/jboss/builder/ProduceFlags.java
@@ -24,22 +24,27 @@
  */
 public final class ProduceFlags extends Flags<ProduceFlag, ProduceFlags> {
 
+    @Override
     protected ProduceFlags value(final int bits) {
         return values[bits & enumValues.length - 1];
     }
 
+    @Override
     protected ProduceFlags this_() {
         return this;
     }
 
+    @Override
     protected ProduceFlag itemOf(final int index) {
         return enumValues[index];
     }
 
+    @Override
     protected ProduceFlag castItemOrNull(final Object obj) {
         return obj instanceof ProduceFlag ? (ProduceFlag) obj : null;
     }
 
+    @Override
     protected ProduceFlags castThis(final Object obj) {
         return (ProduceFlags) obj;
     }

diff --git a/builder/src/main/java/org/jboss/builder/diag/Diagnostic.java b/builder/src/main/java/org/jboss/builder/diag/Diagnostic.java
@@ -60,6 +60,7 @@ public void print(PrintStream os) {
         os.println();
     }
 
+    @Override
     public String toString() {
         StringBuilder b = new StringBuilder();
         if (location != null) {
@@ -93,6 +94,7 @@ public enum Level {
             this.name = name;
         }
 
+        @Override
         public String toString() {
             return name;
         }

diff --git a/builder/src/main/java/org/jboss/builder/item/SymbolicBuildItem.java b/builder/src/main/java/org/jboss/builder/item/SymbolicBuildItem.java
@@ -35,14 +35,17 @@ public static SymbolicBuildItem getInstance() {
         return INSTANCE;
     }
 
+    @Override
     public int hashCode() {
         return 0;
     }
 
+    @Override
     public boolean equals(final Object obj) {
         return obj == this;
     }
 
+    @Override
     public String toString() {
         return "symbolic";
     }

diff --git a/builder/src/main/java/org/jboss/builder/location/Location.java b/builder/src/main/java/org/jboss/builder/location/Location.java
@@ -31,10 +31,12 @@ public Location getParent() {
         return parent;
     }
 
+    @Override
     public boolean equals(final Object obj) {
         return obj instanceof Location && Objects.equals(parent, ((Location) obj).getParent());
     }
 
+    @Override
     public int hashCode() {
         return Objects.hashCode(parent);
     }

diff --git a/builder/src/test/java/org/jboss/builder/BasicTests.java b/builder/src/test/java/org/jboss/builder/BasicTests.java
@@ -36,6 +36,7 @@ public void testSimple() throws ChainBuildException, BuildException {
         final BuildChainBuilder builder = BuildChain.builder();
         final AtomicBoolean ran = new AtomicBoolean();
         BuildStepBuilder stepBuilder = builder.addBuildStep(new BuildStep() {
+            @Override
             public void execute(final BuildContext context) {
                 ran.set(true);
                 context.produce(new DummyItem());
@@ -54,13 +55,15 @@ public void execute(final BuildContext context) {
     public void testLinked() throws ChainBuildException, BuildException {
         final BuildChainBuilder builder = BuildChain.builder();
         BuildStepBuilder stepBuilder = builder.addBuildStep(new BuildStep() {
+            @Override
             public void execute(final BuildContext context) {
                 context.produce(new DummyItem());
             }
         });
         stepBuilder.produces(DummyItem.class);
         stepBuilder.build();
         stepBuilder = builder.addBuildStep(new BuildStep() {
+            @Override
             public void execute(final BuildContext context) {
                 assertNotNull(context.consume(DummyItem.class));
                 context.produce(new DummyItem2());
@@ -80,6 +83,7 @@ public void testInitial() throws ChainBuildException, BuildException {
         final BuildChainBuilder builder = BuildChain.builder();
         builder.addInitial(DummyItem.class);
         BuildStepBuilder stepBuilder = builder.addBuildStep(new BuildStep() {
+            @Override
             public void execute(final BuildContext context) {
                 assertNotNull(context.consume(DummyItem.class));
                 context.produce(new DummyItem2());
@@ -100,6 +104,7 @@ public void execute(final BuildContext context) {
     public void testPruning() throws ChainBuildException, BuildException {
         final BuildChainBuilder builder = BuildChain.builder();
         BuildStepBuilder stepBuilder = builder.addBuildStep(new BuildStep() {
+            @Override
             public void execute(final BuildContext context) {
                 context.produce(new DummyItem());
             }
@@ -108,6 +113,7 @@ public void execute(final BuildContext context) {
         stepBuilder.build();
         final AtomicBoolean ran = new AtomicBoolean();
         stepBuilder = builder.addBuildStep(new BuildStep() {
+            @Override
             public void execute(final BuildContext context) {
                 assertNotNull(context.consume(DummyItem.class));
                 context.produce(new DummyItem2());
@@ -129,6 +135,7 @@ public void testCircular() {
         final BuildChainBuilder builder = BuildChain.builder();
         builder.addFinal(DummyItem.class);
         BuildStepBuilder stepBuilder = builder.addBuildStep(new BuildStep() {
+            @Override
             public void execute(final BuildContext context) {
                 context.consume(DummyItem2.class);
                 context.produce(new DummyItem());
@@ -138,6 +145,7 @@ public void execute(final BuildContext context) {
         stepBuilder.consumes(DummyItem2.class);
         stepBuilder.build();
         stepBuilder = builder.addBuildStep(new BuildStep() {
+            @Override
             public void execute(final BuildContext context) {
                 context.consume(DummyItem.class);
                 context.produce(new DummyItem2());

diff --git a/...loyment/src/main/java/org/jboss/shamrock/deployment/logging/LoggingResourceProcessor.java b/...loyment/src/main/java/org/jboss/shamrock/deployment/logging/LoggingResourceProcessor.java
@@ -389,6 +389,7 @@ static final class ProcessorClassOutput implements ClassOutput {
             this.producer = producer;
         }
 
+        @Override
         public void write(final String name, final byte[] data) {
             producer.produce(new GeneratedClassBuildItem(false, name, data));
         }

diff --git a/core/deployment/src/main/java/org/jboss/shamrock/deployment/steps/StaticInitDebugStep.java b/core/deployment/src/main/java/org/jboss/shamrock/deployment/steps/StaticInitDebugStep.java
@@ -39,8 +39,10 @@
 public class StaticInitDebugStep {
 
     private static final BiFunction<String, ClassVisitor, ClassVisitor> TRANSFORMER = new BiFunction<String, ClassVisitor, ClassVisitor>() {
+        @Override
         public ClassVisitor apply(final String className, final ClassVisitor classVisitor) {
             return new ClassVisitor(Opcodes.ASM6, classVisitor) {
+                @Override
                 public MethodVisitor visitMethod(final int access, final String name, final String descriptor, final String signature, final String[] exceptions) {
                     final MethodVisitor outer = super.visitMethod(access, name, descriptor, signature, exceptions);
                     if (name.equals("<clinit>")) {

diff --git a/core/deployment/src/main/java/org/jboss/shamrock/runner/RuntimeClassLoader.java b/core/deployment/src/main/java/org/jboss/shamrock/runner/RuntimeClassLoader.java
@@ -294,6 +294,7 @@ public void setTransformers(Map<String, List<BiFunction<String, ClassVisitor, Cl
         this.bytecodeTransformers = functions;
     }
 
+    @Override
     public void writeResource(String name, byte[] data) throws IOException {
         resources.put(name, data);
     }

diff --git a/core/deployment/src/main/java/org/jboss/shamrock/runner/RuntimeLoggingConfigurator.java b/core/deployment/src/main/java/org/jboss/shamrock/runner/RuntimeLoggingConfigurator.java
@@ -35,10 +35,12 @@ public class RuntimeLoggingConfigurator implements EmbeddedConfigurator {
 
     static final Config config = ConfigProvider.getConfig();
 
+    @Override
     public Level getMinimumLevelOf(final String loggerName) {
         return Level.ALL;
     }
 
+    @Override
     public Level getLevelOf(final String loggerName) {
         Config config = getConfig();
         Optional<String> level = config.getOptionalValue("shamrock.log.category." + loggerName + ".level", String.class);
@@ -67,6 +69,7 @@ public Level getLevelOf(final String loggerName) {
         return Level.INFO;
     }
 
+    @Override
     public Handler[] getHandlersOf(final String loggerName) {
         Config config = getConfig();
         String format = config.getOptionalValue("shamrock.log.console.format", String.class)

diff --git a/core/runtime/src/main/java/org/jboss/shamrock/runtime/Application.java b/core/runtime/src/main/java/org/jboss/shamrock/runtime/Application.java
@@ -171,13 +171,15 @@ public final void run(String[] args) {
         try {
             if (ImageInfo.inImageRuntimeCode()) {
                 final SignalHandler handler = new SignalHandler() {
+                    @Override
                     public void handle(final Signal signal) {
                         System.exit(0);
                     }
                 };
                 Signal.handle(new Signal("INT"), handler);
                 Signal.handle(new Signal("TERM"), handler);
                 Signal.handle(new Signal("QUIT"), new SignalHandler() {
+                    @Override
                     public void handle(final Signal signal) {
                         DiagnosticPrinter.printDiagnostics(System.out);
                     }
@@ -229,6 +231,7 @@ class ShutdownHookThread extends Thread {
             setDaemon(false);
         }
 
+        @Override
         public void run() {
             shutdownRequested = true;
             LockSupport.unpark(mainThread);
@@ -244,6 +247,7 @@ public void run() {
             }
         }
 
+        @Override
         public String toString() {
             return getName();
         }

diff --git a/core/runtime/src/main/java/org/jboss/shamrock/runtime/ExecutorTemplate.java b/core/runtime/src/main/java/org/jboss/shamrock/runtime/ExecutorTemplate.java
@@ -57,6 +57,7 @@ public Executor setupRunTime(ShutdownContext shutdownContext, int defaultCoreSiz
         builder.setKeepAliveTime(getIntConfigVal("executor.keep-alive-millis", defaultKeepAliveMillis), TimeUnit.MILLISECONDS);
         final EnhancedQueueExecutor executor = builder.build();
         shutdownContext.addShutdownTask(new Runnable() {
+            @Override
             public void run() {
                 executor.shutdown();
                 for (;;) try {

diff --git a/creator/src/main/java/org/jboss/shamrock/creator/AppDependency.java b/creator/src/main/java/org/jboss/shamrock/creator/AppDependency.java
@@ -71,6 +71,7 @@ public boolean equals(Object obj) {
         return true;
     }
 
+    @Override
     public String toString() {
         return artifact.toString() + '(' + scope + ')';
     }

diff --git a/creator/src/main/java/org/jboss/shamrock/creator/util/PropertyUtils.java b/creator/src/main/java/org/jboss/shamrock/creator/util/PropertyUtils.java
@@ -52,6 +52,7 @@ public static String getProperty(final String name) {
        final SecurityManager sm = System.getSecurityManager();
        if(sm != null) {
            return AccessController.doPrivileged(new PrivilegedAction<String>(){
+               @Override
                public String run() {
                    return System.getProperty(name);
                }});

diff --git a/ext/arc/processor/src/main/java/org/jboss/protean/arc/processor/BuiltinBean.java b/ext/arc/processor/src/main/java/org/jboss/protean/arc/processor/BuiltinBean.java
@@ -45,6 +45,7 @@
 enum BuiltinBean {
 
     INSTANCE(DotNames.INSTANCE, new Generator() {
+        @Override
         void generate(ClassOutput classOutput, BeanDeployment beanDeployment, InjectionPointInfo injectionPoint, ClassCreator clazzCreator,
                 MethodCreator constructor, String providerName, AnnotationLiteralProcessor annotationLiterals) {
 
@@ -75,20 +76,23 @@ void generate(ClassOutput classOutput, BeanDeployment beanDeployment, InjectionP
 
         }
     }), INJECTION_POINT(DotNames.INJECTION_POINT, new Generator() {
+        @Override
         void generate(ClassOutput classOutput, BeanDeployment beanDeployment, InjectionPointInfo injectionPoint, ClassCreator clazzCreator,
                 MethodCreator constructor, String providerName, AnnotationLiteralProcessor annotationLiterals) {
             // this.injectionPointProvider1 = new InjectionPointProvider();
             constructor.writeInstanceField(FieldDescriptor.of(clazzCreator.getClassName(), providerName, InjectableReferenceProvider.class.getName()),
                     constructor.getThis(), constructor.newInstance(MethodDescriptor.ofConstructor(InjectionPointProvider.class)));
         }
     }), BEAN(DotNames.BEAN, new Generator() {
+        @Override
         void generate(ClassOutput classOutput, BeanDeployment beanDeployment, InjectionPointInfo injectionPoint, ClassCreator clazzCreator,
                 MethodCreator constructor, String providerName, AnnotationLiteralProcessor annotationLiterals) {
             // this.beanProvider1 = new BeanMetadataProvider<>();
             constructor.writeInstanceField(FieldDescriptor.of(clazzCreator.getClassName(), providerName, InjectableReferenceProvider.class.getName()),
                     constructor.getThis(), constructor.newInstance(MethodDescriptor.ofConstructor(BeanMetadataProvider.class)));
         }
     }), BEAN_MANAGER(DotNames.BEAN_MANAGER, new Generator() {
+        @Override
         void generate(ClassOutput classOutput, BeanDeployment beanDeployment, InjectionPointInfo injectionPoint, ClassCreator clazzCreator,
                 MethodCreator constructor, String providerName, AnnotationLiteralProcessor annotationLiterals) {
             constructor.writeInstanceField(FieldDescriptor.of(clazzCreator.getClassName(), providerName, InjectableReferenceProvider.class.getName()),

diff --git a/ext/arc/processor/src/main/java/org/jboss/protean/arc/processor/InterceptorInfo.java b/ext/arc/processor/src/main/java/org/jboss/protean/arc/processor/InterceptorInfo.java
@@ -119,6 +119,7 @@ boolean intercepts(InterceptionType interceptionType) {
         }
     }
 
+    @Override
     public boolean isInterceptor() {
         return true;
     }

diff --git a/ext/arc/runtime/src/main/java/org/jboss/protean/arc/AbstractSharedContext.java b/ext/arc/runtime/src/main/java/org/jboss/protean/arc/AbstractSharedContext.java
@@ -65,6 +65,7 @@ public void destroy(Contextual<?> contextual) {
         }
     }
 
+    @Override
     public synchronized void destroy() {
         instances.forEachExistingValue(InstanceHandleImpl::destroyInternal);
         instances.clear();

diff --git a/ext/arc/runtime/src/main/java/org/jboss/protean/arc/GenericArrayTypeImpl.java b/ext/arc/runtime/src/main/java/org/jboss/protean/arc/GenericArrayTypeImpl.java
@@ -35,6 +35,7 @@ public GenericArrayTypeImpl(Class<?> rawType, Type... actualTypeArguments) {
         this.genericComponentType = new ParameterizedTypeImpl(rawType, actualTypeArguments);
     }
 
+    @Override
     public Type getGenericComponentType() {
         return genericComponentType;
     }

diff --git a/ext/arc/runtime/src/main/java/org/jboss/protean/arc/InjectableBean.java b/ext/arc/runtime/src/main/java/org/jboss/protean/arc/InjectableBean.java
@@ -46,6 +46,7 @@ public interface InjectableBean<T> extends Bean<T>, InjectableReferenceProvider<
      *
      * @return the scope
      */
+    @Override
     default Class<? extends Annotation> getScope() {
         return Dependent.class;
     }
@@ -54,12 +55,14 @@ default Class<? extends Annotation> getScope() {
      *
      * @return the set of bean types
      */
+    @Override
     Set<Type> getTypes();
 
     /**
      *
      * @return the set of qualifiers
      */
+    @Override
     default Set<Annotation> getQualifiers() {
         return Qualifiers.DEFAULT_QUALIFIERS;
     }

diff --git a/ext/arc/runtime/src/main/java/org/jboss/protean/arc/InstanceHandle.java b/ext/arc/runtime/src/main/java/org/jboss/protean/arc/InstanceHandle.java
@@ -57,6 +57,7 @@ default InjectableBean<T> getBean() {
     /**
      * Delegates to {@link #destroy()}.
      */
+    @Override
     default void close() {
         destroy();
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,6 +19,7 @@ @@
     /**
      */
     final class FinalStep implements BuildStep {
+        @Override
         public void execute(final BuildContext context) {
         }
@@ Expand Down @@