Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for console dark mode #2004

Closed
emmanuelbernard opened this issue Apr 11, 2019 · 2 comments
Closed

Add documentation for console dark mode #2004

emmanuelbernard opened this issue Apr 11, 2019 · 2 comments
Labels
area/documentation area/logging triage/out-of-date This issue/PR is no longer valid or relevant

Comments

@emmanuelbernard
Copy link
Member

Today the property is quarkus.log.console.darken / QUARKUS_LOG_CONSOLE_DARKEN
Let's add a documentation in the log guide.
@geoand
Copy link
Contributor

geoand commented Apr 11, 2019 •
edited
Loading

There is a slight problem however, when one adds quarkus.log.console.darken to application.properties that value is ignored (because https://github.com/quarkusio/quarkus/blob/master/core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingResourceProcessor.java#L116 takes precedence) - see #1989
The environment variable however works just fine.

@gsmet
Copy link
Member

gsmet commented Nov 13, 2019

This is included in the doc now.

@gsmet gsmet closed this as completed Nov 13, 2019
@gsmet gsmet added the triage/out-of-date This issue/PR is no longer valid or relevant label Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/documentation area/logging triage/out-of-date This issue/PR is no longer valid or relevant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@emmanuelbernard @cescoffier @gsmet @geoand