Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GZIP in GraphQL Services #21642

Closed
funcbro opened this issue Nov 23, 2021 · 8 comments · Fixed by #35767
Closed

Support for GZIP in GraphQL Services #21642

funcbro opened this issue Nov 23, 2021 · 8 comments · Fixed by #35767
Assignees
Milestone

Comments

@funcbro
Copy link

funcbro commented Nov 23, 2021

Description

The GraphQL extension io.quarkus:quarkus-smallrye-graphql currently does not support GZIP compression of responses.

GZIP compression of GraphQL-responses should be configurable.

When looking at the smallrye implementation itself, it should be possible to implement a GZIP compression via a Servlet Response-Filter.
By using the quarkus extension though this possibility does not seem to exist.

Implementation ideas

No response

@funcbro funcbro added the kind/enhancement New feature or request label Nov 23, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 23, 2021

/cc @jmartisk, @phillip-kruger

@phillip-kruger
Copy link
Member

Thanks for this issue. The Quarkus extension does not use servlet for the HTTP transport. But we should be able to add this to the vertx route. I'll have a look a.s.a.p.

@phillip-kruger phillip-kruger self-assigned this Nov 23, 2021
@funcbro
Copy link
Author

funcbro commented Apr 28, 2022

any news on this issue?

@phillip-kruger
Copy link
Member

No news yet. You are welcome to do a PR if you want. The change would probably be somewhere in the Quarkus GraphQL Extension Runtime

@www-wanglong
Copy link

I just need it.

@gsmet
Copy link
Member

gsmet commented Aug 22, 2023

If we are using a Vert.x route, shouldn’t this be already supported with @mkouba ’s work?

@mkouba
Copy link
Contributor

mkouba commented Aug 22, 2023

If we are using a Vert.x route, shouldn’t this be already supported with @mkouba ’s work?

I don't think so. IIRC the compression support was not added to Vert.x routes in general but into Reactive Routes, RESTEasy Reactive, Undertow Servlet, RESTEasy Classsic and static resources. More specifically, if quarkus.http.enable-compression=true then we add the Content-Encoding: identity header that disables the compression to every response and the task of the support is to remove this header if appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants