-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile.jvm build fails with kaniko: user: unknown user 1001 #25499
Comments
Seems reasonable. @maxandersen WDYT? |
Hmmm - doesn't this end up conflicting with kuberneteS/openshift owner ids? |
According to the proposal, we wouldn't change the user ids, we'd just run |
As long as we can verify It still works in openshift It's fine. I.e. take particular notice of https://docs.openshift.com/container-platform/4.2/openshift_images/create-images.html section of "support arbitrary user ids" |
Summoning @rsvoboda for this :) |
giving my two cents if I can :) IMHO, there's a concern here that it's adding a new layer to the image with more libraries that another set of users probably don't need. May I suggest creating some cli option to give developers the option to choose to create the user? |
If we are concerned about the extra layer, then I would not go so far as to add a new flag to the Dockerfile. We could just keep the commands in the Dockerfile but commented out with an explanation of when it might make sense to use them. |
After that, adding some documentation on website telling gitlab users to uncomment those lines. |
Makes sense |
Would be handy to have kubernetes/openshift checks (#17674) in place. |
@geoand @weltonrodrigo I think this issue is gone thanks to the changes in c24179a. The new template is no longer using the user 1001 (I could reproduce this issue and after updating the Dockerfile, it works fine in OpenShift). |
Thanks for investigating @Sgitario! Let's close this in light of the information you mention above. |
Describe the bug
This is a known bug in kaniko GoogleContainerTools/kaniko#1456, where commands like
COPY --chown=1001 target/quarkus-app/lib/ /deployments/lib/
fail with:
It would be nice, as the kaniko bug is >1 year old, that quarkus could provided a (probably harmless) workaround on it's Dockerfiles:
This bug makes quarkus impossible to build on gitlab CICD, as a kaniko build is the recommended way to build a docker image there.
Expected behavior
No response
Actual behavior
No response
How to Reproduce?
No response
Output of
uname -a
orver
No response
Output of
java -version
No response
GraalVM version (if different from Java)
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: