Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config: reflect a breaking change of package config in the docs #40272

Closed
mkouba opened this issue Apr 25, 2024 · 3 comments · Fixed by #40277
Closed

Config: reflect a breaking change of package config in the docs #40272

mkouba opened this issue Apr 25, 2024 · 3 comments · Fixed by #40277
Labels
area/config area/documentation area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Milestone
3.10.1

Comments

@mkouba
Copy link
Contributor

mkouba commented Apr 25, 2024

Description

#39295 introduced a breaking change that is neither reflected in the docs nor mentioned in the migration guide. The DecompilerConfig was moved to JarConfig group; as a result the quarkus.package.decompiler.enabled property that is used in the docs does not work anymore. The current property name is quarkus.package.jar.decompiler.enabled. The same applies to quarkus.package.decompiler.jar-directory. I did not check the other parts of the package config.

TBH I'm not quite sure such a change makes sense. But we should definitely document all breaking changes. I think that we should treat the config properties as a part of the public API.

Implementation ideas

No response
@mkouba mkouba added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Apr 25, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 25, 2024

/cc @radcortez (config)

@mkouba
Copy link
Contributor Author

mkouba commented Apr 25, 2024

CC @dmlloyd

@dmlloyd
Copy link
Member

dmlloyd commented Apr 25, 2024

Ah. I started my patch before vineflower was renamed to decompiler, and that one did get missed.

dmlloyd added a commit to dmlloyd/quarkus that referenced this issue Apr 25, 2024
@dmlloyd
Fix accidental config breakage of quarkus.package.decompiler.* prop…
4b02893 
…erties

This was missed in quarkusio#39295. Fixes quarkusio#40272.
@dmlloyd dmlloyd mentioned this issue Apr 25, 2024
Merged
dmlloyd added a commit to dmlloyd/quarkus that referenced this issue Apr 29, 2024
@dmlloyd
Fix accidental config breakage of quarkus.package.decompiler.* prop…
21ce678 
…erties

This was missed in quarkusio#39295. Fixes quarkusio#40272.
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone Apr 30, 2024
@gsmet gsmet modified the milestones: 3.11 - main, 3.10.1 May 10, 2024
gsmet pushed a commit to gsmet/quarkus that referenced this issue May 10, 2024
@dmlloyd @gsmet
Fix accidental config breakage of quarkus.package.decompiler.* prop…
7ed1eb0 
…erties

This was missed in quarkusio#39295. Fixes quarkusio#40272.

(cherry picked from commit 21ce678)
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue Jul 31, 2024
@dmlloyd @holly-cummins
Fix accidental config breakage of quarkus.package.decompiler.* prop…
1a388d4 
…erties

This was missed in quarkusio#39295. Fixes quarkusio#40272.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/config area/documentation area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
Quarkus Documentation
Status: Done
Milestone
3.10.1
Development

Successfully merging a pull request may close this issue.

Fix accidental config breakage of quarkus.package.decompiler.* properties dmlloyd/quarkus
3 participants
@dmlloyd @mkouba @gsmet