Kubernetes extension crashes with NPE during build

[adutra]

Describe the bug

Possibly caused by #38748.

When upgrading to Quarkus 3.10, the Kubernetes extension started throwing an NPE during build (see stacktrace below). The same project builds fine with Quarkus 3.9.

Workaround: adding the config option quarkus.kubernetes.vcs-uri.enabled=false makes the build pass.

Expected behavior

No build errors.

Actual behavior

> There was a failure while executing work items
   > A failure occurred while executing io.quarkus.gradle.tasks.worker.BuildWorker
      > io.quarkus.builder.BuildException: Build failure: Build failed due to errors
                [error]: Build step io.quarkus.kubernetes.deployment.VanillaKubernetesProcessor#createDecorators threw an exception: java.lang.NullPointerException: Cannot invoke "String.indexOf(int)" because "remoteUrl" is null
                at io.dekorate.utils.Git.sanitizeRemoteUrl(Git.java:135)
                at io.quarkus.kubernetes.deployment.KubernetesCommonHelper.lambda$parseVCSUri$64(KubernetesCommonHelper.java:1198)
                at java.base/java.util.Optional.orElseGet(Optional.java:364)
                at io.quarkus.kubernetes.deployment.KubernetesCommonHelper.parseVCSUri(KubernetesCommonHelper.java:1198)
                at io.quarkus.kubernetes.deployment.KubernetesCommonHelper.lambda$createAnnotationDecorators$56(KubernetesCommonHelper.java:977)
                at java.base/java.util.Optional.ifPresent(Optional.java:178)
                at io.quarkus.kubernetes.deployment.KubernetesCommonHelper.createAnnotationDecorators(KubernetesCommonHelper.java:975)
                at io.quarkus.kubernetes.deployment.KubernetesCommonHelper.createDecorators(KubernetesCommonHelper.java:255)
                at io.quarkus.kubernetes.deployment.VanillaKubernetesProcessor.createDecorators(VanillaKubernetesProcessor.java:164)
                at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
                at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
                at java.base/java.lang.reflect.Method.invoke(Method.java:568)
                at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:849)
                at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
                at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
                at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2516)
                at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2495)
                at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1521)
                at java.base/java.lang.Thread.run(Thread.java:833)
                at org.jboss.threads.JBossThread.run(JBossThread.java:483)

How to Reproduce?

1. Checkout this project and branch: Kubernetes Operator for Nessie projectnessie/nessie#7967
2. Edit operator/src/main/resources/application.properties, remove line 16: quarkus.kubernetes.vcs-uri.enabled=false
3. Run ./gradlew :nessie-operator:build in the repo root.

Output of uname -a or ver

Darwin MacBook-Pro.local 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:12:37 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6031 arm64

Output of java -version

openjdk version "17.0.6" 2023-01-17 OpenJDK Runtime Environment Temurin-17.0.6+10 (build 17.0.6+10) OpenJDK 64-Bit Server VM Temurin-17.0.6+10 (build 17.0.6+10, mixed mode)

Quarkus version or git rev

3.10.0

Build tool (ie. output of mvnw --version or gradlew --version)

------------------------------------------------------------ Gradle 8.7 ------------------------------------------------------------ Build time: 2024-03-22 15:52:46 UTC Revision: 650af14d7653aa949fce5e886e685efc9cf97c10 Kotlin: 1.9.22 Groovy: 3.0.17 Ant: Apache Ant(TM) version 1.10.13 compiled on January 4 2023 JVM: 17.0.6 (Eclipse Adoptium 17.0.6+10) OS: Mac OS X 14.4.1 aarch64

Additional information

No response

[quarkus-bot]

/cc @geoand (kotlin,kubernetes), @iocanel (kubernetes)

[adutra]

FYI I do have many remotes defined, and one of them is origin.

[geoand]

Thanks for reporting!

Sounds like an easy fix, but it would be in Dekorate, not Quarkus itself

[adutra]

Yes I imagined. That said, on the Quarkus side, we might want to test if scm.getRemote().get("origin") is null... not everyone has a remote called origin ;-)

[geoand]

That sounds like a very specific workaround 😀

[gsmet]

While I agree we need a fix in Dekorate, I also think our code in Quarkus is unnecessarily brittle.

I created #40596 to avoid pushing null to the Dekorate method.

@adutra can you check the PR?