Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write an ADR explaining how clients should use the TLS registry #41042

Closed
cescoffier opened this issue Jun 7, 2024 · 3 comments · Fixed by #41126
Closed

Write an ADR explaining how clients should use the TLS registry #41042

cescoffier opened this issue Jun 7, 2024 · 3 comments · Fixed by #41126
Assignees
@cescoffier
Labels
area/adr area/config
Milestone
3.13.0.CR1

Comments

@cescoffier
Copy link
Member

Description

See #40990 (comment) to see the rationale.

So, we should use a named configuration for the clients. Otherwise, it will likely conflict with servers. Note that multiple clients (like the REST client and the mailer) may use the same TLS configuration - just not the default one.

Follow up from #40990.

Implementation ideas

No response
@cescoffier cescoffier added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Jun 7, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jun 7, 2024

/cc @radcortez (config)

@cescoffier cescoffier self-assigned this Jun 7, 2024
@geoand
Copy link
Contributor

geoand commented Jun 7, 2024

I would say the scope should be to explain how clients should use the registry, not just why they should not use the default one :)

@cescoffier cescoffier mentioned this issue Jun 7, 2024
Merged
@cescoffier cescoffier changed the title Write an ADR explaining why clients should not use the default TLS configurartion Write an ADR explaining how clients should use the TLS comfig registry Jun 7, 2024
@cescoffier cescoffier changed the title Write an ADR explaining how clients should use the TLS comfig registry Write an ADR explaining how clients should use the TLS registry Jun 9, 2024
@cescoffier cescoffier removed the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Jun 10, 2024
@cescoffier cescoffier moved this from Todo to In Progress in WG - Enhanced TLS support Jun 11, 2024
@cescoffier
Copy link
Member Author

Fixed by #41126.

@cescoffier cescoffier mentioned this issue Jun 11, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in WG - Enhanced TLS support Jun 12, 2024
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cescoffier cescoffier

Labels
area/adr area/config
Projects
WG - Enhanced TLS support
Status: Done
Milestone
3.13.0.CR1
2 participants
@cescoffier @geoand