Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI in version 3.8.5 does not properly update #42567

Closed
mocenas opened this issue Aug 15, 2024 · 8 comments
Closed

CLI in version 3.8.5 does not properly update #42567

mocenas opened this issue Aug 15, 2024 · 8 comments
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) kind/bug Something isn't working
Milestone

Comments

@mocenas
Copy link
Contributor

mocenas commented Aug 15, 2024

Describe the bug

Using quarkus 3.8.5 I cannot update app from 3.2.12.Final to 3.8.5. Update process reports no issues, just does not do any changes.
It can be reproduced by creating app using CLI and trying to update it. Attaching update.log from that.

Switching quarkus CLI to 3.12.3 solves the problem. Using that version of CLI it works no problem.

Expected behavior

App will be update to 3.8.5. Especially quarkus version in pom.xml

Actual behavior

No changes were made.

How to Reproduce?

Use quarkus CLI 3.8.5

  1. quarkus create app app --stream=3.2
  2. cd app
  3. quarkus update --stream=3.8

Output of uname -a or ver

No response

Output of java -version

17

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

quarkus CLI

Additional information

No response

@mocenas mocenas added the kind/bug Something isn't working label Aug 15, 2024
@quarkus-bot quarkus-bot bot added the area/cli Related to quarkus cli (not maven/gradle/etc.) label Aug 15, 2024
Copy link

quarkus-bot bot commented Aug 15, 2024

/cc @ebullient (cli), @maxandersen (cli)

@gsmet
Copy link
Member

gsmet commented Aug 15, 2024

The key in your log is:

[INFO] --- rewrite:5.36.0:run (default-cli) @ upstreamApp ---
[INFO] Using active recipe(s) []
[INFO] Using active styles(s) []

It doesn't apply anything.

Now we need to figure out why :).

To clarify, what doesn't work is:

  • use Quarkus CLI 3.8.5
  • update to 3.8.5

What does work:

  • use Quarkus CLI 3.12.3
  • update to 3.8.5

Can you confirm?

@mocenas
Copy link
Contributor Author

mocenas commented Aug 15, 2024

To clarify, what doesn't work is:

* use Quarkus CLI 3.8.5

* update to 3.8.5

What does work:

* use Quarkus CLI 3.12.3

* update to 3.8.5

Can you confirm?

Yes that is true.

@gsmet
Copy link
Member

gsmet commented Aug 15, 2024

I wonder if it could be related to this thing I fixed for 3.12: 634a851

@gsmet
Copy link
Member

gsmet commented Aug 15, 2024

/cc @rsvoboda to have it on your radar for 3.8.6

@mocenas
Copy link
Contributor Author

mocenas commented Aug 15, 2024

I wonder if it could be related to this thing I fixed for 3.12: 634a851

Yes it does help. When I manually run update command with these changes, it works.

@gsmet
Copy link
Member

gsmet commented Aug 15, 2024

@mocenas cool, thanks for confirming, I will backport this to 3.8.6!

@gsmet
Copy link
Member

gsmet commented Aug 15, 2024

I pushed this commit to #42547 so we should be all good for 3.8.6.

Thanks for the report!

@gsmet gsmet closed this as completed Aug 15, 2024
@gsmet gsmet added this to the 3.8.6 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants