Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io.quarkus.grpc.cli.GrpcCliTest.testCommand fails CI and makes it next to impossible to get green CI #42819

Open
michalvavrik opened this issue Aug 27, 2024 · 3 comments
Assignees
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/grpc gRPC area/housekeeping Issue type for generalized tasks not related to bugs or enhancements

Comments

@michalvavrik
Copy link
Member

michalvavrik commented Aug 27, 2024

Description

I am experiencing in this PR #42749 that after several runs I can't get green CI because of this test. According to the build scan history https://ge.quarkus.io/scans/tests?search.timeZoneId=Europe%2FPrague&tests.container=io.quarkus.grpc.cli.GrpcCliTest&tests.test=testCommand it is not just my PR. For example I found same failure in #42700 from @gsmet. I believe we need to disable this test with link to this issue so that the issue is not forgotten, but also, other PRs are not blocked.

Example stacktrace:

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.vertx.http.deployment.VertxHttpProcessor#cors threw an exception: java.lang.IllegalStateException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at io.quarkus.deployment.proxy.ProxyFactory.newInstance(ProxyFactory.java:281)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl.getProxyInstance(BytecodeRecorderImpl.java:409)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl$1.invoke(BytecodeRecorderImpl.java:351)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl$$RecordingProxyProxy25.corsHandler(Unknown Source)
	at io.quarkus.vertx.http.deployment.VertxHttpProcessor.cors(VertxHttpProcessor.java:169)

Implementation ideas

  1. Disable the test Disable GrpcCliTest#testCommand due to CI failures #42820
  2. Fix the test.
@michalvavrik michalvavrik added area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/grpc gRPC labels Aug 27, 2024
@quarkus-bot quarkus-bot bot added the area/cli Related to quarkus cli (not maven/gradle/etc.) label Aug 27, 2024
Copy link

quarkus-bot bot commented Aug 27, 2024

/cc @alesj (grpc), @cescoffier (grpc), @ebullient (cli), @maxandersen (cli)

@alesj
Copy link
Contributor

alesj commented Aug 28, 2024

Yeah, this just won't go away ... and the problem is probably not the test, it's something more general ... @gsmet should know more.

@cescoffier
Copy link
Member

@gsmet @alesj any news about this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/grpc gRPC area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
Development

No branches or pull requests

3 participants