Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBangIntegration needs some TLC ASAP #43681

Closed
dmlloyd opened this issue Oct 3, 2024 · 1 comment · Fixed by #43718
Closed

JBangIntegration needs some TLC ASAP #43681

dmlloyd opened this issue Oct 3, 2024 · 1 comment · Fixed by #43718
Labels
area/jbang Issues related to when using jbang.dev with Quarkus kind/bug Something isn't working priority/urgent
Milestone

Comments

@dmlloyd
Copy link
Member

dmlloyd commented Oct 3, 2024

Describe the bug

When trying to update jboss-threads in #43648/#43634 a JBang integration test has started to fail. Long story short, classes from jbang.jar are leaking on to the Quarkus class path somehow. It's likely related to one or more of the various (probably obsolete) class resolution workarounds which can be found in io.quarkus.launcher.JBangIntegration in the core/launcher submodule.

This code needs to be reviewed to see if any of these workarounds are still needed and/or if they are causing issues like the one described above.

Expected behavior

No class path leakage.

Actual behavior

Lots of class path leakage!

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@dmlloyd dmlloyd added the kind/bug Something isn't working label Oct 3, 2024
@quarkus-bot quarkus-bot bot added the area/jbang Issues related to when using jbang.dev with Quarkus label Oct 3, 2024
Copy link

quarkus-bot bot commented Oct 3, 2024

/cc @maxandersen (jbang), @quarkusio/devtools (jbang)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jbang Issues related to when using jbang.dev with Quarkus kind/bug Something isn't working priority/urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants