Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduling does not fail boot if a cron expression is invalid #462

Closed
stuartwdouglas opened this issue Jan 10, 2019 · 2 comments · Fixed by #470
Closed

Scheduling does not fail boot if a cron expression is invalid #462

stuartwdouglas opened this issue Jan 10, 2019 · 2 comments · Fixed by #470
Assignees
@mkouba
Labels
kind/bug Something isn't working
Milestone
0.6.0

Comments

@stuartwdouglas
Copy link
Member 

2019-01-10 16:12:33,140 stuarts-macbook-pro surefirebooter5197709413870105999.jar[59466] WARN  [o.j.s.s.r.QuartzScheduler] (main) Invalid CRON expression: {schedulerservice.cron.expr}: java.util.NoSuchElementException: Property schedulerservice.cron.expr not found
	at io.smallrye.config.SmallRyeConfig.getValue(SmallRyeConfig.java:58)
	at org.jboss.shamrock.scheduler.runtime.QuartzScheduler.start(QuartzScheduler.java:178)
	at org.jboss.shamrock.scheduler.runtime.QuartzScheduler_Observer1.notify(Unknown Source)
@mkouba mkouba self-assigned this Jan 10, 2019
@mkouba
Copy link
Contributor

mkouba commented Jan 10, 2019

Yep, a known issue: https://github.com/jbossas/protean-shamrock/blob/master/extensions/scheduler/deployment/src/main/java/org/jboss/shamrock/scheduler/deployment/SchedulerProcessor.java#L171 ;-)

@mkouba mkouba added this to the 0.6.0 milestone Jan 10, 2019
@mkouba mkouba added the kind/bug Something isn't working label Jan 10, 2019
@mkouba
Copy link
Contributor

mkouba commented Jan 10, 2019

Actually, we can validate static values during build and config-based values during bootstrap.

@mkouba mkouba mentioned this issue Jan 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkouba mkouba

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Scheduler - validate cron() and every() expressions mkouba/protean-shamrock
2 participants
@stuartwdouglas @mkouba