Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new platform resolver code work in native app #4941

Closed
ia3andy opened this issue Oct 28, 2019 · 6 comments
Closed

Make new platform resolver code work in native app #4941

ia3andy opened this issue Oct 28, 2019 · 6 comments
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Oct 28, 2019

I've tried to setup Code Quarkus to compile to native with master and the new resolver. It always misses some classes:
quarkusio/code.quarkus.io#194

The reflection file is there:
https://github.com/quarkusio/code.quarkus.io/pull/194/files#diff-92f9ada386b472dc5e9b8b6990b7a8a7

To reproduce:

$ make native
// Then
$./target/code.quarkus.io-1.0.0-runner  
@ia3andy ia3andy added the kind/bug Something isn't working label Oct 28, 2019
@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 28, 2019

@aloubyansky could you help make it work?

@ia3andy ia3andy changed the title Make Platform resolver code work in native app Make new platform resolver code work in native app Oct 28, 2019
@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 28, 2019

Once this is running, you need to make sure you can generate applications using the running webapp.

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 28, 2019

@aloubyansky maybe the solution is just to change the code so that it doesn't use those at all.. (maybe I don't have all your recent code for that)

@emmanuelbernard
Copy link
Member

Btw unrelated but @ia3andy you should not use the reflection object and instead write extensions to do that work :)

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 28, 2019

@emmanuelbernard yes for sure, I just never took the time to actually do it 😬

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 28, 2019

I created an issue for it: #4944

@ia3andy ia3andy closed this as completed Oct 29, 2019
@gsmet gsmet added this to the 0.27.0 milestone Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants