Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hibernate always bump version upon merge calls involving entities without change #7770

Closed
emmanuelbernard opened this issue Mar 11, 2020 · 4 comments
Labels
area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE kind/bug Something isn't working

Comments

@emmanuelbernard
Copy link
Member

emmanuelbernard commented Mar 11, 2020

Upon merge of a reattached entity deserialized from Jackson and Lombok, we see a different of behavior between 1.2.1.Final and 1.3.1.CR2
See #7462 for the original info.
Possibly related to #2815

This issue is here to follow up specifically on the version issue.

@emmanuelbernard emmanuelbernard added the kind/bug Something isn't working label Mar 11, 2020
@quarkusbot
Copy link

/cc @gsmet @Sanne

@quarkusbot quarkusbot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Mar 11, 2020
@emmanuelbernard
Copy link
Member Author

CC @masini
So Sanne and I did a debug session. We have a version of your version bump test that does not use lombok, and yours that uses lombok.
What we found is that in Quarkus 1.2.1.Final, the lombok entity does not implement SelfDirtinessTracker which makes the test in AbstractEntityEntry.onFlushEntity might be dirty field to be false because AbstractEntityEntry.isUnequivocallyNonDirty does not use the SelfDirtinessTracker

Now it turns out that due to this, your version test works as expected with Lombok but that's a bug hiding a bug :)

Now in Quarkus 1.3.0.CR2, Lombok works as expected and implements SelfDirtinessTracker. Likely because we improved the classloader infrastructure. But now we surface this bug on version.
And @Sanne strongly suspects we are back to this issue #2815

@masini
Copy link
Contributor

masini commented Mar 12, 2020

@emmanuelbernard @Sanne thanks for taking your time on this issue.

So my test was testing that the bug was on, fantastic !!

I'll update them and watch #2815

Have a nice day

@yrodiere
Copy link
Member

Hey.
As far as I understand, Emmanuel's analysis revealed there's nothing to see here, and the real problem is #2815. So I'll close this issue. Feel free to ping me if that's a mistake.

@yrodiere yrodiere closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants