Only wrap exceptions when necessary in ArC subclassing #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, the proxy has an exception handling as similar as possible to the original class. Fixes #329.
mkouba
requested changes
Dec 18, 2018
| @@ -65,6 +65,9 @@ | |||
| */ | |||
| public class SubclassGenerator extends AbstractGenerator { | |||
|
|
|||
| private static final DotName JAVA_LANG_EXCEPTION = DotName.createSimple(Exception.class.getName()); | |||
There was a problem hiding this comment.
Pls use org.jboss.protean.arc.processor.DotNames.create(Class<?>) instead - this constructs a componentized DotName which is more efficient when comparing names from an index.
There was a problem hiding this comment.
Good to know, added a commit to fix that.
- I took
Throwableproperly into account, even if not strictly necessary.
Also take into account Throwable, even if not critical - it works OK without it.
mkouba
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the proxy has an exception handling as similar as possible to
the original class.
Fixes #329.
My initial inclination was to add the test in
SubclassGeneratorTestbut I couldn't figure out how to properly initialize my bean (and ended up with a lot of boilerplate code reimplementing a lot of logic). So I ended up moving the test in arc-tests to have the test infrastructure handy.