Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow * expression for quarkus:add-extension #3672

Merged
merged 1 commit into from
Aug 25, 2019
Merged

Allow * expression for quarkus:add-extension #3672

merged 1 commit into from
Aug 25, 2019

Conversation

Dufgui
Copy link
Contributor

@Dufgui Dufgui commented Aug 23, 2019

fix #1234

@Dufgui Dufgui force-pushed the 1234_regexpExtension branch from a45828e to db5e87d Compare August 23, 2019 13:20
cescoffier
cescoffier requested changes Aug 23, 2019
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a comment about the tests.
This should also be documented somewhere.

devtools/common/src/test/java/io/quarkus/cli/commands/AddExtensionsTest.java Show resolved Hide resolved
@Dufgui Dufgui force-pushed the 1234_regexpExtension branch from 6090bda to 6b6ee36 Compare August 24, 2019 15:23
@Dufgui Dufgui force-pushed the 1234_regexpExtension branch from 6b6ee36 to 678942b Compare August 24, 2019 15:50
@Dufgui
Copy link
Contributor Author

Dufgui commented Aug 24, 2019

I add doc, and I fix the conf about the plugin in gradle and missing doc of addExtension
@cescoffier @aloubyansky

@cescoffier cescoffier added this to the 0.22.0 milestone Aug 25, 2019
@cescoffier cescoffier merged commit 1ca793c into quarkusio:master Aug 25, 2019
@FWest98 FWest98 mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/gradle Gradle area/maven kind/enhancement New feature or request
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

Allow * expression for quarkus:add-extension
2 participants
@Dufgui @cescoffier