Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn beans from info extension into ApplicationScoped #40178

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 22, 2024

@manovotn
Copy link
Contributor

I suppose those beans were originally @Singleton just to keep them minimal (i.e. avoid having to have proxy created) and I don't expect this to create trouble.
Either way, it would be nice to have some tests added - ideally with the use case from #40152

@geoand
Copy link
Contributor Author

geoand commented Apr 22, 2024

I suppose those beans were originally @singleton just to keep them minimal (i.e. avoid having to have proxy created)

Exactly.

Either way, it would be nice to have some tests added - ideally with the use case from

I could, but that would mean adding a new Maven module. Given that we try to avoid that unless it's necessary (due to the size of the project) and the fact that this type of thing has been tested a lot for other components, I'd rather avoid it for now.

@geoand geoand requested a review from gsmet April 24, 2024 11:24
@gsmet gsmet merged commit 4fe7808 into quarkusio:main Apr 26, 2024
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone Apr 26, 2024
@gsmet gsmet modified the milestones: 3.11 - main, 3.10.1 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot mock GitInfo using @MockitoConfig(convertScopes = true)
3 participants