VertxCoreProcessor and HibernateValidatorProcessor bytecode transformers are safe to be cached

[Sanne]

This is a small improvement affecting memory consumption during live-reload.

[Sanne]

The failed test has been unstable for a long time apparently :(

• https://ge.quarkus.io/scans/tests?search.relativeStartTime=P90D&search.timeZoneId=Europe%2FLondon&tests.container=io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest&tests.test=testUpdatingConnector

[Sanne]

Should probably be rebased on top of #40203

[Sanne]

It passed all tests but I'm pushing a new version now which uses the Builder to create the same build-items, so making it better maintainable and to avoid conflicts with #40203

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ccd92be.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

---

Flaky tests - Develocity

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/maven

✖ io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratch - History

• Cannot delete directory: target\test-classes\projects\project-generation - java.lang.RuntimeException

java.lang.RuntimeException: Cannot delete directory: target\test-classes\projects\project-generation
	at io.quarkus.maven.it.MojoTestBase.initEmptyProject(MojoTestBase.java:72)
	at io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratch(CreateProjectMojoIT.java:60)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.apache.commons.io.IOExceptionList: 1 exception(s): [org.apache.commons.io.IOIndexedException: IOException #0: Cannot delete file: target\test-classes\projects\project-generation\build-create-project-generation.log]
	at org.apache.commons.io.IOExceptionList.checkEmpty(IOExceptionList.java:50)

✖ io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratch - History

• Cannot delete directory: target\test-classes\projects\project-generation - java.lang.RuntimeException

java.lang.RuntimeException: Cannot delete directory: target\test-classes\projects\project-generation
	at io.quarkus.maven.it.MojoTestBase.initEmptyProject(MojoTestBase.java:72)
	at io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratch(CreateProjectMojoIT.java:60)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.apache.commons.io.IOExceptionList: 1 exception(s): [org.apache.commons.io.IOIndexedException: IOException #0: Cannot delete file: target\test-classes\projects\project-generation\build-create-project-generation.log]
	at org.apache.commons.io.IOExceptionList.checkEmpty(IOExceptionList.java:50)

[Sanne]

@mkouba as the topic is fresh in your mind, could I ask you for a review?

[mkouba]

👍 seems safe to cache both transformations.