Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow two star role-name in web-fragment.xml as described in servlet spec #40237

Merged
merged 1 commit into from
May 1, 2024

Conversation

paulpunk
Copy link

@paulpunk paulpunk commented Apr 24, 2024

I use a dependency with a web-fragment.xml like this

<auth-constraint>
   <role-name>**</role-name>
</auth-constraint>

This causes all calls to the servlets to be denied.

It would work with <role-name>*</role-name>
According to the servlet specification section 13.8, both "*" and "**" should be fine. This pr fixes the issue (firstly i thought also other parts of undertow would have to be changed, but this change alone is sufficient), i tried it out locally.

@paulpunk paulpunk force-pushed the two_star_rolename branch from ae64f2c to af92c31 Compare April 24, 2024 08:08
@paulpunk paulpunk force-pushed the two_star_rolename branch 4 times, most recently from 40a7379 to a11ff35 Compare April 29, 2024 05:46
@sberyozkin
Copy link
Member

@stuartwdouglas Can you please check this PR ?

@paulpunk paulpunk force-pushed the two_star_rolename branch from a11ff35 to 084eddf Compare May 1, 2024 07:03
Copy link

quarkus-bot bot commented May 1, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 084eddf.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin merged commit f4894a6 into quarkusio:main May 1, 2024
47 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants