Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split dependabot into two groups #40276

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Split dependabot into two groups #40276

merged 1 commit into from
Apr 25, 2024

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Apr 25, 2024

This should fix the timeout issues. The two groups are equally-sized and just divided in the middle. The time is offset by one hour, since the timeout is less than that.

@dmlloyd
Split dependabot into two groups
7f489ca 
This should fix the timeout issues. The two groups are equally-sized and just divided in the middle. The time is offset by one hour, since the timeout is less than that.
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure labels Apr 25, 2024
@dmlloyd
Copy link
Member Author

dmlloyd commented Apr 25, 2024

Note: I'm not certain whether multiple of the same package-ecosystem is supported or not. I figure, there's at least one way to find out...

gsmet
gsmet approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I have a question though: why didn't I think about doing that months ago...

Let's how it goes in the next few days.

@gsmet gsmet merged commit a350062 into quarkusio:main Apr 25, 2024
3 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone Apr 25, 2024
@dmlloyd dmlloyd deleted the dependabot branch April 25, 2024 14:09
@dmlloyd
Copy link
Member Author

dmlloyd commented Apr 25, 2024

Uh oh!

Dependabot encountered the following error when parsing your .github/dependabot.yml:

Update configs must have a unique combination of 'package-ecosystem', 'directory', and 'target-branch'
Please update the config file to conform with Dependabot's specification.

@dmlloyd
Copy link
Member Author

dmlloyd commented Apr 25, 2024

Maybe one half could have target-branch: main and the other not given?

@gastaldi
Copy link
Contributor

gastaldi commented Apr 25, 2024 •
edited
Loading

That's weird, you have tested in your fork before submitting, right? 😅

@dmlloyd
Copy link
Member Author

dmlloyd commented Apr 25, 2024

That's weird, you have tested in your fork before submitting, right? 😅

I guess I didn't realize that was possible!

@dmlloyd
Copy link
Member Author

dmlloyd commented Apr 25, 2024

Maybe one half could have target-branch: main and the other not given?

I guess that won't work :( Oh well, revert time.

@dmlloyd dmlloyd mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi left review comments

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Milestone
3.11.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@dmlloyd @gastaldi @gsmet