Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring OIDC state cookie age #40316

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Apr 26, 2024

Closes #40268.

The situation in #40268 was confirmed to be resolved, but I'd like to close it with a somewhat related hardening improvement - if the state cookies are lost for some reasons, at least their age is controlled and is not set for the reasons I don't recall now to 30 mins which is a way too long for state cookies and the browser will clear these cookies much faster.
It will also let users manage the expectations how long an authorization code flow can run. For example, if the user has been redirected to authenticate to the OIDC provider and the state cookie is set to 3 mins but the user is returned back in 20 mins (why ?) then the browser will lose the state cookie and the authentication will have to be restarted.

Also updated the OIDC code flow doc, changed the TOC along the way a bit to make some sections more visible.

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation area/oidc labels Apr 26, 2024
Copy link

quarkus-bot bot commented Apr 26, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 24d346f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

github-actions bot commented Apr 26, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Apr 26, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 24d346f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin merged commit 22aedce into quarkusio:main Apr 26, 2024
25 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone Apr 26, 2024
@sberyozkin sberyozkin deleted the oidc_state_cookie_age branch April 26, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

State cookies (q_auth) keeps piling up in code flow
2 participants