Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute: add integration test for test templates #40411

Merged
merged 1 commit into from
May 2, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented May 2, 2024

  • i.e. add a test with templates in both (1) src/main/resources/templates and (2) src/test/resources/templates

This is a follow-up of #40400 and I've verified that it failed before the fix.

@mkouba mkouba requested review from aloubyansky and ia3andy May 2, 2024 10:22
@quarkus-bot quarkus-bot bot added the area/qute The template engine label May 2, 2024
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 2, 2024

This comment has been minimized.

@mkouba mkouba force-pushed the qute-test-src-templates branch from 984d88d to 60abaf5 Compare May 2, 2024 10:55

This comment has been minimized.

@mkouba
Copy link
Contributor Author

mkouba commented May 2, 2024

The failures are related but it does not seem to be a Qute-related problem; it fails with RESTEASY003210: Could not find resource for full path: http://localhost:8081/hi?name=Ciri as if the JAX-RS resource from the src/test/java is not added to the native image. When I changed the quarkus-resteasy-qute dependency to quarkus-rest-qute I can observe a different problem - quarkus-reactive-routes is not included in the app at all 🤔.

@mkouba mkouba force-pushed the qute-test-src-templates branch from 60abaf5 to 1097daa Compare May 2, 2024 12:15

This comment has been minimized.

- i.e. add a test with templates in both (1)
src/main/resources/templates and (2) src/test/resources/templates
@mkouba mkouba force-pushed the qute-test-src-templates branch from 1097daa to 5a17f1d Compare May 2, 2024 13:00
@mkouba
Copy link
Contributor Author

mkouba commented May 2, 2024

The failures are related but it does not seem to be a Qute-related problem; it fails with RESTEASY003210: Could not find resource for full path: http://localhost:8081/hi?name=Ciri as if the JAX-RS resource from the src/test/java is not added to the native image.

It was a PEBKAC of mine - obviously, a JAX-RS resource located in src/test may not be part of the native image under the test 🤦.

I can observe a different problem - quarkus-reactive-routes is not included in the app at all 🤔.

And this was probably some build cache problem.

Copy link

quarkus-bot bot commented May 2, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5a17f1d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit e3e3950 into quarkusio:main May 2, 2024
20 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 2, 2024
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qute The template engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants