Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more clarity around code-block in Dev UI Docs #40426

Merged
merged 1 commit into from
May 3, 2024

Conversation

phillip-kruger
Copy link
Member

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
Copy link

quarkus-bot bot commented May 3, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 852dd85.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

github-actions bot commented May 3, 2024

🙈 The PR is closed and the preview is expired.

@holly-cummins
Copy link
Contributor

Approving, because these changes look good, and should be merged - but they might be incomplete, since I found the dev UI pages with a code block went blank on moving to 3.9.1, and these changes weren't enough to fix it. It looks like @phillip-kruger can't reproduce, though, so we will have to figure out what the issue is and if it's strictly local or could affect other users/extensions.

@phillip-kruger phillip-kruger requested a review from cescoffier May 3, 2024 10:38
@holly-cummins
Copy link
Contributor

I confirm the issue I was seeing was user error (thanks, @phillip-kruger!), so this is good to go.

@cescoffier cescoffier merged commit 9d92610 into quarkusio:main May 3, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 3, 2024
@gsmet gsmet modified the milestones: 3.11 - main, 3.10.1 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants