Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid "Failed to index" warnings produced during @SecureField annotation detection #40448

Merged

Conversation

michalvavrik
Copy link
Member

fixes: #40153

Copy link

quarkus-bot bot commented May 3, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit f473250.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

github-actions bot commented May 3, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented May 3, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f473250.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@michalvavrik michalvavrik requested review from geoand and gsmet May 6, 2024 17:23
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@gsmet gsmet merged commit 143e083 into quarkusio:main May 10, 2024
34 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 10, 2024
@michalvavrik michalvavrik deleted the feature/secure-field-warning-logs branch May 10, 2024 11:55
@gsmet gsmet modified the milestones: 3.11 - main, 3.10.1 May 10, 2024
@vmuzikar
Copy link

@michalvavrik @gsmet Will this get backported to 3.8?

@michalvavrik
Copy link
Member Author

@michalvavrik @gsmet Will this get backported to 3.8?

I've added a backport label, let's see how it gets accepted.

@rsvoboda
Copy link
Member

There is QUARKUS-4431 request on product side.

@vmuzikar this fix was included in Quarkus 3.10.1 released ~1 hour ago, so this doesn't have any bake time.
Is this a must-have for 3.8.5 or would it be ok to wait till 3.8.6 to get community feedback?

@vmuzikar
Copy link

@rsvoboda If you are not comfortable with including it last minute in 3.8.5, that's fine for Keycloak. What is the estimated time frame for 3.8.6? Based on that we'll filter the messages on our end.

@rsvoboda
Copy link
Member

Bits are out now and it's usually week or two to get feedback in case something goes wrong.

So assuming we are not under immediate pressure to get 3.8.5 out, we could include this in the last 3.8.5 backports round.

@vmuzikar
Copy link

Ok, 3.8.5 would be awesome. :)

@gsmet gsmet modified the milestones: 3.10.1, 3.8.5 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Many "Failed to index" warnings since 3.9.1
5 participants