-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArC: custom context can get CurrentContextFactory during instantiation #40618
Conversation
...ts/arc/tests/src/test/java/io/quarkus/arc/test/buildextension/context/CustomContextTest.java
Outdated
Show resolved
Hide resolved
...ts/arc/tests/src/test/java/io/quarkus/arc/test/buildextension/context/CustomContextTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2403b8a
to
8fb92cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left just a nitpicker note, otherwise LGTM
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/ContextCreator.java
Outdated
Show resolved
Hide resolved
8fb92cf
to
012c9fe
Compare
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
No description provided.