Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArC: custom context can get CurrentContextFactory during instantiation #40618

Merged
merged 1 commit into from
May 14, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented May 14, 2024

No description provided.

@mkouba mkouba requested review from Ladicek and manovotn May 14, 2024 07:37
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label May 14, 2024
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkouba mkouba force-pushed the arc-custom-context-ccf branch from 2403b8a to 8fb92cf Compare May 14, 2024 07:54
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left just a nitpicker note, otherwise LGTM

@mkouba mkouba force-pushed the arc-custom-context-ccf branch from 8fb92cf to 012c9fe Compare May 14, 2024 12:37
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 14, 2024

This comment has been minimized.

Copy link

quarkus-bot bot commented May 14, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 012c9fe.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit fb25191 into quarkusio:main May 14, 2024
51 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 14, 2024
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants