Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Keycloak version to 24.0.4 #40662

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented May 15, 2024

This upgrade is possible with thanks to @pedroigor suggesting to use a JSON file at the startup which allows Keycloak to avoid enforcing that an attribute like email is required during the new user registration or authentication.

@sberyozkin sberyozkin requested review from gastaldi and pedroigor May 15, 2024 15:19
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/documentation area/keycloak area/oidc labels May 15, 2024

This comment has been minimized.

Copy link

github-actions bot commented May 15, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@sberyozkin
Copy link
Member Author

Sorry, I thought I tried most of the integration tests :-), will look at it tomorrow

@sberyozkin
Copy link
Member Author

It was just an error message that got changed in a negative test for the unsupported token exchange feature

Copy link

quarkus-bot bot commented May 15, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 52207f7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented May 16, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 52207f7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin
Copy link
Member Author

Let me merge this one

@sberyozkin sberyozkin merged commit f7b8d69 into quarkusio:main May 16, 2024
54 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 16, 2024
@sberyozkin sberyozkin deleted the keycloak_24.0.4 branch May 16, 2024 10:12
@aloubyansky
Copy link
Member

@rsvoboda @gastaldi @gsmet afaiu, we need this in 3.8 to align with the supported version of Keycloak

@rsvoboda
Copy link
Member

This is fail of coordination between Keycloak and Quarkus. Such a big change should have been merged into main much sooner, https://github.com/keycloak/keycloak/releases/tag/24.0.0 was released Mar 4.

I don't like such a big change coming in without bake time.

@gsmet gsmet modified the milestones: 3.12 - main, 3.8.5 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants