-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to asynchronously notify extensions of no-restart changes #40682
Conversation
Tested with web-bundler |
This comment has been minimized.
This comment has been minimized.
5a08fc6
to
9f763bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
core/deployment/src/main/java/io/quarkus/deployment/dev/RuntimeUpdatesProcessor.java
Outdated
Show resolved
Hide resolved
9f763bb
to
bf266dc
Compare
Status for workflow
|
scanLock.lock(); | ||
codeGenLock.lock(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the new locks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the context, I want to make sure this won't cause problems as you asked for a backport.
This allows a clean way to notify extensions of no-restart changes like there: quarkiverse/quarkus-web-bundler#217:
This also allows to reset the compileProblem asynchronously.
For context, when the change is already handled/compiled by the underlying process, triggering a doScan() is not necessary and could even be an issue. Still, extensions needs to be notified of the change.