Make sure we transmit the actual debug port to next dev mode run #41043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting dev mode, the debug port might not be free and we might use a random one. When restarting dev mode (for instance when you adjust the pom.xml), we should try to reuse this port instead of defaulting to the initially non free one. Also the port being free is tested when we build `DevModeRunner`, so we need to make sure we stop the old runner before build()ing the new instance (and not just before we start the new one). Fixes quarkusio#40848
quarkus-bot
bot
added
area/core
area/devtools
geoand
reviewed
Jun 7, 2024
|
|
||
| // stop the runner before we build the new one as the debug port being free | ||
| // is tested when building the runner | ||
| runner.stop(); |
There was a problem hiding this comment.
Do we need to do this in Gradle as well?
There was a problem hiding this comment.
Your guess is as good as mine :). I will try to have a look.
There was a problem hiding this comment.
I don't see the restart logic in Gradle but I'm not very familiar with how it works.
Maybe @glefloch or @aloubyansky know more.
But I wouldn't block this PR as the current Maven behavior is a bit annoying.
geoand
approved these changes
Jun 7, 2024
Status for workflow
|
|
We don't support restarts on Gradle build script changes atm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting dev mode, the debug port might not be free and we might use a random one.
When restarting dev mode (for instance when you adjust the pom.xml), we should try to reuse this port instead of defaulting to the initially non free one.
Also the port being free is tested when we build
DevModeRunner, so we need to make sure we stop the old runner before build()ing the new instance (and not just before we start the new one).Fixes #40848