Add GraphQL Footer Log in Dev UI #43483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
phillip-kruger
force-pushed
the
dev-ui-gql-log
branch
from
c33b896 to
078ee61
Compare
|
@jmartisk ^^^ |
Status for workflow
|
cescoffier
approved these changes
Oct 18, 2024
|
Looks cool, I'll have to keep it in mind to potentially add more interesting stuff into the log producer in the future. I don't know if it's completely kosher to include the full queries and responses in the logs, but given that it's dev-only, it should be fine I guess |
jmartisk
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to wait for a new release of SmallRye GraphQL that includes this PR: smallrye/smallrye-graphql#2197
/cc @jmartisk