Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realign JUnit versions and update to 5.10.5 #43917

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Oct 16, 2024

For now, we can't upgrade to 5.11 due to how they changed hierarchy handling.
So let's make sure we are aligned on 5.10.3 everywhere by reverting the upgrades that went in.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/platform Issues related to definition and interaction with Quarkus Platform labels Oct 16, 2024
@jorsol
Copy link
Contributor

jorsol commented Oct 16, 2024

Why not 5.10.5? is affected too?

This comment has been minimized.

@gsmet gsmet changed the title Realign JUnit versions on 5.10.3 Realign JUnit versions and update to 5.10.5 Oct 17, 2024
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file labels Oct 17, 2024
@gsmet
Copy link
Member Author

gsmet commented Oct 17, 2024

@jorsol I just got back to the version we were using before the 5.11 update but you're right, let's try 5.10.5 and see how it goes.

Copy link

quarkus-bot bot commented Oct 17, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8cd6f2c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

@gsmet gsmet requested a review from gastaldi October 17, 2024 14:15
@gsmet gsmet merged commit 5c3944b into quarkusio:main Oct 17, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 17, 2024
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.0 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/platform Issues related to definition and interaction with Quarkus Platform triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants