Update MP REST Client to 4.0 #43959

radcortez · 2024-10-18T12:20:43Z

MicroProfile REST Client Release notes:

4.0

New overloaded `baseUri(String uri)` method so users don’t have to call URI.create()

New `header(String name, Object value)` method for adding headers to Client instances

Clarify specification CDI support (`@RestClient` qualifier is not optional)

Add multi-part processing example to specification.

Clarify the specification that when a client injected as a CDI bean falls out of scope, the client is closed

MicroProfile Rest Client Spec PDF
MicroProfile Rest Client Spec HTML
MicroProfile Rest Client Spec Javadocs

github-actions · 2024-10-18T12:54:49Z

🎊 PR Preview de27583 has been successfully built and deployed to https://quarkus-pr-main-43959-preview.surge.sh/version/main/guides/

Images of blog posts older than 3 months are not available.
Newsletters older than 3 months are not available.

gsmet

Thanks! It looks mostly good to me except for some minor suggestions.

I would prefer for @geoand to have a look though.

...src/main/java/io/quarkus/rest/client/reactive/runtime/DefaultClientHeadersRequestFilter.java

tcks/microprofile-rest-client-reactive/pom.xml

...time/src/main/java/org/jboss/resteasy/reactive/client/handlers/ClientSendRequestHandler.java

...asy-client/runtime/src/main/java/io/quarkus/restclient/runtime/QuarkusRestClientBuilder.java

Co-authored-by: Guillaume Smet <guillaume.smet@gmail.com>

geoand · 2024-10-21T17:15:32Z

extensions/resteasy-classic/resteasy-client/runtime/pom.xml

+        <dependency>
+            <groupId>org.jboss.resteasy</groupId>
+            <artifactId>resteasy-multipart-provider</artifactId>
+        </dependency>


Not that I mind, but I would like to know why this is now necessary

Also if it's necessary, we might have to depend on the quarkus-resteasy-multipart extension instead.

This is the dependency from RESTEasy that provides the EntityPart.Builder implementation. Note that for the REST Client Classic, I've tried to keep it as the original implementation: resteasy/resteasy-microprofile@bb8b433

geoand · 2024-10-21T17:16:45Z

...asy-client/runtime/src/main/java/io/quarkus/restclient/runtime/QuarkusRestClientBuilder.java

+            return Stream.of(type.getMethods())
+                    .filter(method -> !IGNORED_METHODS.contains(method))
+                    .toArray(Method[]::new);


I'm definitely no fan of this, but we can let it go in :)

Yes, this is a copy from the original RESTEasy Builder code:
resteasy/resteasy-microprofile@cb58ceb

Initially, we used the one provided by RESTEasy, but we made a copy to remove references to their CDI integration and also to remove the CDI dependency. They diverged a bit, so I've tried to reconcile them again for consistency.

geoand

Thanks!!

quarkus-bot · 2024-10-21T17:29:39Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit 6c4a5b6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2024-10-21T22:41:07Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 6c4a5b6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/grpc/deployment

✖ io.quarkus.grpc.server.devmode.GrpcDevModeTest.testProtoFileChangeAndImplementationReload - History

/home/runner/work/quarkus/quarkus/extensions/grpc/deployment/target/quarkus-dev-mode-test16620780450342298993/target/classes/io/grpc/testing/integration/Messages$SimpleResponse$1.class - java.nio.file.NoSuchFileException

java.nio.file.NoSuchFileException: /home/runner/work/quarkus/quarkus/extensions/grpc/deployment/target/quarkus-dev-mode-test16620780450342298993/target/classes/io/grpc/testing/integration/Messages$SimpleResponse$1.class
	at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:92)
	at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106)
	at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111)
	at java.base/sun.nio.fs.UnixFileAttributeViews$Basic.readAttributes(UnixFileAttributeViews.java:55)
	at java.base/sun.nio.fs.UnixFileSystemProvider.readAttributes(UnixFileSystemProvider.java:148)
	at java.base/sun.nio.fs.LinuxFileSystemProvider.readAttributes(LinuxFileSystemProvider.java:99)
	at java.base/java.nio.file.Files.readAttributes(Files.java:1851)

📦 integration-tests/infinispan-cache

✖ io.quarkus.it.cache.infinispan.InfinspanCacheClientTestCase.test - History

expected: <false> but was: <true> - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
	at io.quarkus.it.cache.infinispan.InfinspanCacheClientTestCase.invalidate(InfinspanCacheClientTestCase.java:77)

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/opentelemetry/deployment

✖ io.quarkus.opentelemetry.deployment.metrics.HttpServerMetricsTest.collectsHttpRouteFromEndAttributes - History

Assertion condition defined as a Lambda expression in io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter expected: <true> but was: <false> within 5 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter expected: <true> but was: <false> within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter.assertCountPointsAtLeast(InMemoryMetricExporter.java:131)
	at io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter_ClientProxy.assertCountPointsAtLeast(Unknown Source)

rsvoboda · 2024-10-24T08:11:27Z

No description, noteworthy label, or indication if there are implications on end-user applications ...
@radcortez would you please cover that?

michalvavrik · 2024-10-24T08:20:58Z

I have opened issue here #44067 because it cost me time to find this. Please document this. There is no PR description, there is no migration guide change, there is no documentation change. Thank you

radcortez · 2024-10-24T10:20:45Z

No description, noteworthy label, or indication if there are implications on end-user applications ... @radcortez would you please cover that?

The reported issue in #44067 is not caused by this change, which is a very simple one with zero impact on the end user.

It is caused by #43345, which completely describes the changes, including the breaking changes.

michalvavrik · 2024-10-24T11:04:39Z

It is caused by #43345, which completely describes the changes, including the breaking changes.

I apologize for my mistake. I don't think any of comments requesting documentation and PR description were wrong and it is true that there were no migration guide note, but again, my bad. I didn't find #43345 with my GH query, I will have to adjust my filter or rebuild Quarkus next time.

radcortez · 2024-10-24T11:18:58Z

No worries, all good. I usually include a Breaking Changes description in the PR, but only in the Migration Guide after the PR is merged because we can't be sure which version the PR will merge. #43345 was merged recently, so it was still on my TODO list to copy the breaking changes to the Migration Guide.

rsvoboda · 2024-10-24T11:21:58Z

About stuff mentioned in #43959 (comment), noteworthy label should be applied, wdyt?
And some description / link would be handy too, this is major version change.

radcortez · 2024-10-24T12:02:27Z

Updated!

quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/rest area/rest-client area/resteasy-classic labels Oct 18, 2024

quarkusio deleted a comment from quarkus-bot bot Oct 18, 2024

This comment has been minimized.

Sign in to view

gsmet reviewed Oct 21, 2024

View reviewed changes

geoand reviewed Oct 21, 2024

View reviewed changes

...asy-client/runtime/src/main/java/io/quarkus/restclient/runtime/QuarkusRestClientBuilder.java Show resolved Hide resolved

radcortez force-pushed the resteasy-client branch from 2e2996e to 95b1469 Compare October 21, 2024 15:51

This comment has been minimized.

Sign in to view

radcortez force-pushed the resteasy-client branch from 95b1469 to 9028324 Compare October 21, 2024 16:35

This comment has been minimized.

Sign in to view

Update MP REST Client to 4.0

6c4a5b6

Co-authored-by: Guillaume Smet <guillaume.smet@gmail.com>

radcortez force-pushed the resteasy-client branch from 9028324 to 6c4a5b6 Compare October 21, 2024 16:49

geoand reviewed Oct 21, 2024

View reviewed changes

geoand approved these changes Oct 21, 2024

View reviewed changes

quarkus-bot bot added the triage/flaky-test label Oct 21, 2024

gsmet merged commit 1a1a941 into quarkusio:main Oct 23, 2024
54 checks passed

quarkus-bot bot added this to the 3.17 - main milestone Oct 23, 2024

michalvavrik mentioned this pull request Oct 24, 2024

Quarkus REST client is unable to determine base URI with MP-style properties after MP bump and I can't see anything documented #44067

Closed

radcortez added the release/noteworthy-feature label Oct 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update MP REST Client to 4.0 #43959

Update MP REST Client to 4.0 #43959

radcortez commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

gsmet left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

geoand Oct 21, 2024

gsmet Oct 21, 2024

radcortez Oct 21, 2024

geoand Oct 21, 2024

radcortez Oct 21, 2024

geoand left a comment •

edited

Loading

quarkus-bot bot commented Oct 21, 2024

quarkus-bot bot commented Oct 21, 2024 •

edited by github-actions bot

Loading

rsvoboda commented Oct 24, 2024

michalvavrik commented Oct 24, 2024 •

edited

Loading

radcortez commented Oct 24, 2024

michalvavrik commented Oct 24, 2024

radcortez commented Oct 24, 2024

rsvoboda commented Oct 24, 2024

radcortez commented Oct 24, 2024

Update MP REST Client to 4.0 #43959

Update MP REST Client to 4.0 #43959

Conversation

radcortez commented Oct 18, 2024 • edited Loading

4.0

github-actions bot commented Oct 18, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

gsmet left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

geoand Oct 21, 2024

Choose a reason for hiding this comment

gsmet Oct 21, 2024

Choose a reason for hiding this comment

radcortez Oct 21, 2024

Choose a reason for hiding this comment

geoand Oct 21, 2024

Choose a reason for hiding this comment

radcortez Oct 21, 2024

Choose a reason for hiding this comment

geoand left a comment • edited Loading

Choose a reason for hiding this comment

quarkus-bot bot commented Oct 21, 2024

Status for workflow Quarkus Documentation CI

quarkus-bot bot commented Oct 21, 2024 • edited by github-actions bot Loading

Status for workflow Quarkus CI

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/grpc/deployment

📦 integration-tests/infinispan-cache

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/opentelemetry/deployment

rsvoboda commented Oct 24, 2024

michalvavrik commented Oct 24, 2024 • edited Loading

radcortez commented Oct 24, 2024

michalvavrik commented Oct 24, 2024

radcortez commented Oct 24, 2024

rsvoboda commented Oct 24, 2024

radcortez commented Oct 24, 2024

radcortez commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

geoand left a comment •

edited

Loading

Status for workflow `Quarkus Documentation CI`

quarkus-bot bot commented Oct 21, 2024 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`

michalvavrik commented Oct 24, 2024 •

edited

Loading