Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undertow: ignore missing servlet class in web.xml #44063

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Undertow: ignore missing servlet class in web.xml #44063

merged 1 commit into from
Oct 24, 2024

Conversation

rodcheater
Copy link
Contributor

Avoids writing a null bean name to the bean archive, which causes a later build failure.

Fixes #43825

@rodcheater
Undertow: ignore missing servlet class in web.xml
df4696b 
Avoids writing a null bean name to the bean archive, which causes a
later build failure.

Fixes quarkusio#43825
@rodcheater rodcheater force-pushed the 43825-ignore-missing-servlet-class-in-web-xml branch from eb01531 to df4696b Compare October 24, 2024 05:11
gsmet
gsmet approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Oct 24, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit df4696b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet
Copy link
Member

gsmet commented Oct 24, 2024

@geoand given you suggested the change, I let you have a look at it before merging!

@geoand
Copy link
Contributor

geoand commented Oct 24, 2024

I did? I have no recollection of that

@gsmet
Copy link
Member

gsmet commented Oct 24, 2024

Ah sorry, it was @mkouba :).

@gsmet gsmet merged commit ae7c297 into quarkusio:main Oct 24, 2024
48 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 24, 2024
@gsmet
Copy link
Member

gsmet commented Oct 24, 2024

Thanks!

@gsmet gsmet modified the milestones: 3.17 - main, 3.16.1 Oct 28, 2024
@gsmet gsmet modified the milestones: 3.16.1, 3.15.2 Nov 13, 2024
@jcarranzan jcarranzan mentioned this pull request Nov 26, 2024
Merged
9 tasks
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Nov 26, 2024
@jcarranzan
Add test coverage for the issue quarkusio/quarkus#43825
f467527 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Nov 26, 2024
@jcarranzan
Add test coverage for the issue quarkusio/quarkus#43825
dded4bb 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Nov 26, 2024
@jcarranzan
Add test coverage for the issue quarkusio/quarkus#43825
b27147e 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Nov 26, 2024
@jcarranzan
Add test coverage for the issue quarkusio/quarkus#43825
d44135f 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Nov 26, 2024
@jcarranzan
Add test coverage for the issue quarkusio/quarkus#43825
db07f2f 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Nov 26, 2024
@jcarranzan
Add test coverage for the issue quarkusio/quarkus#43825
5430f97 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Nov 27, 2024
@jcarranzan
Add test coverage for the issue quarkusio/quarkus#43825
925676a 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Nov 27, 2024
@jcarranzan
Add test coverage for the issue quarkusio/quarkus#43825
c942424 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Nov 27, 2024
@jcarranzan
Add test coverage for the issue quarkusio/quarkus#43825
49f299a 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario
jcarranzan added a commit to quarkus-qe/quarkus-test-suite that referenced this pull request Nov 27, 2024
@jcarranzan
Add test coverage for the issue quarkusio/quarkus#43825
f215332 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Nov 28, 2024
@jcarranzan
Add test coverage for the issue quarkusio/quarkus#43825
e131cbe 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario

(cherry picked from commit 49f299a)
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Nov 28, 2024
@jcarranzan
Add test coverage for the issue quarkusio/quarkus#43825
4dc969a 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Nov 28, 2024
@jcarranzan
Add test coverage for the issue quarkusio/quarkus#43825
02bb065 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario

(cherry picked from commit 49f299a)
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Nov 28, 2024
@jcarranzan
Add test coverage for the issue quarkusio/quarkus#43825
e46f590 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario

(cherry picked from commit 49f299a)
@jcarranzan jcarranzan mentioned this pull request Nov 28, 2024
Merged
9 tasks
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this pull request Nov 28, 2024
@jcarranzan
Add test coverage for the issue quarkusio/quarkus#43825
3590bd6 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario

(cherry picked from commit 49f299a)
jedla97 pushed a commit to quarkus-qe/quarkus-test-suite that referenced this pull request Nov 28, 2024
@jcarranzan @jedla97
Add test coverage for the issue quarkusio/quarkus#43825
5c24349 
Ensure the missing servlet class in web.xml is ignored

Test coverage for quarkusio/quarkus#44063 scenario

(cherry picked from commit 49f299a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/undertow kind/bugfix
Projects
None yet
Milestone
3.15.2
Development

Successfully merging this pull request may close these issues.

BeanArchiveProcessor#build threw an exception: Local name must not be null
4 participants
@rodcheater @gsmet @geoand @mkouba