Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Elasticsearch DevService network for @QuarkusIntegrationTest for docker-image-building #44119

Conversation

jgardo
Copy link
Contributor

@jgardo jgardo commented Oct 26, 2024

Fixes case specified in #43980

Copy link

quarkus-bot bot commented Oct 26, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not contain an issue number (use Fix #1234 in the description instead)
  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

Copy link

quarkus-bot bot commented Oct 26, 2024

/cc @gsmet (elasticsearch), @loicmathieu (elasticsearch), @marko-bekhta (elasticsearch), @yrodiere (elasticsearch)

@jgardo jgardo changed the title #43980 Fix Elasticsearch DevService network for @QuarkusIntegrationTest for docker-image-building Fix Elasticsearch DevService network for @QuarkusIntegrationTest for docker-image-building Oct 26, 2024
@jgardo
Copy link
Contributor Author

jgardo commented Oct 26, 2024

Basically it works properly for project attached to #43980

Unfortunatelly I couldn't find any test verifying @QuarkusIntegrationTest of created docker image...
Such tests occurred in the past, but they were dropped in PR #31295

I suppose these tests were dropped intentionally, as time of CI build was too long.

@jgardo
Copy link
Contributor Author

jgardo commented Oct 26, 2024

Will be proceeded in: #44120 as MergeCommit occurred in git history

@jgardo jgardo closed this Oct 26, 2024
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Oct 26, 2024
@jgardo jgardo deleted the bugfix/issue-43980-elasticsearch-dev-service branch November 7, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant