Fix Elasticsearch DevService network for @QuarkusIntegrationTest for docker-image-building

[jgardo]

Fixes #43980

Tested manually for project attached to #43980

Unfortunately I couldn't find any test verifying @QuarkusIntegrationTest of created docker image...

Such tests occurred in the past, but they were dropped in PR #31295 . I suppose these tests were dropped intentionally, as time of CI build was too long.

[quarkus-bot]

/cc @gsmet (elasticsearch), @loicmathieu (elasticsearch), @marko-bekhta (elasticsearch), @yrodiere (elasticsearch)

[yrodiere]

LGTM, thank you.

Unfortunately I couldn't find any test verifying @QuarkusIntegrationTest of created docker image...

We do test Elasticsearch dev services, but indeed not with @QuarkusIntegrationTest.

I would personally be in favor of just using dev services in most integration tests, e.g. in integration-tests/elasticsearch-rest-client, instead of relying on separate configuration.
But it's certainly outside the scope of this PR, so please don't do that here, and there might be reasons not to do it -- @geoand would know.

[geoand]

But it's certainly outside the scope of this PR, so please don't do that here, and there might be reasons not to do it -- @geoand would know.

Totally agree. Dev services work just fine with QuarkusIntegrationTest

[yrodiere]

But it's certainly outside the scope of this PR, so please don't do that here, and there might be reasons not to do it -- @geoand would know.

Totally agree. Dev services work just fine with QuarkusIntegrationTest

There might be a misunderstanding here, because that's not what I meant at all. Anyway, I created #44124 to discuss this.

[gsmet]

FWIW, I remember having fixed something similar in another dev service. I wonder if it's something we need to fix globally. Definitely not in the scope of this PR, just thinking out loud.

[gsmet]

To be clear, I was thinking about this PR https://github.com/quarkusio/quarkus/pull/42472/files, where we fix a slightly different issue for MongoDB but it ends up adjusting the same values for different reasons.

[jgardo]

To be clear, I was thinking about this PR https://github.com/quarkusio/quarkus/pull/42472/files, where we fix a slightly different issue for MongoDB but it ends up adjusting the same values for different reasons.

I suppose there are some devservices to fix (at least these using io.quarkus.devservices.common.ConfigureUtil#configureSharedNetwork without storing result hostName).

Personally I also would need to fix Pulsar devservice. So should I create another issue and PR or with same issue with separate PR?

[yrodiere]

Personally I also would need to fix Pulsar devservice. So should I create another issue and PR or with same issue with separate PR?

Please open a separate PR, thanks. No need for a dedicated issue as long as the PR correctly describes the problem.

EDIT: issue => PR, sorry...

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8a2ab24.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.