-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate OIDC, OIDC client and OIDC Client Registration extensions to @ConfigMapping #44140
Migrate OIDC, OIDC client and OIDC Client Registration extensions to @ConfigMapping #44140
Conversation
🎊 PR Preview 269efae has been successfully built and deployed to https://quarkus-pr-main-44140-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
Awesome, thanks @michalvavrik, I'll start reviewing asap, thanks very much |
Yeah, I don't want to hurry you as I know you are busy, but there is one thing: I checked all OIDC PRs between I started working on this and now and there were no relevant change, but if anything that touches OIDC config changes, this PR needs to be updated. Like #44114. So we need to sync with changes in main repo (hopefully it would result in a merge conflict, but I am not 100 % certain). |
3b01a01
to
e9a0833
Compare
I have rebased on current main, adapted this PR to changes made in #44114 (AKA added Slack) and checked PRs this week so far, no relevant changes. It's safe so far. I'll re-check in a few days as well. No hurry. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@michalvavrik Michal, can you type some examples here how for example |
Sorry @michalvavrik, I forgot that phase 1 is only about supporting |
extensions/oidc/runtime/src/test/java/io/quarkus/oidc/runtime/OidcTenantConfigImpl.java
Show resolved
Hide resolved
e9a0833
to
981f8a6
Compare
FYI - I just rebased and checked commits. Looks like nothing relevant changed so I didn't have to do anything. |
Status for workflow
|
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start the migration process, thanks @michalvavrik
Thank you @sberyozkin , I'll open Renarde PR to address this change. (these 2 bracket scenarios) |
@ConfigMapping
#39185 (comment): migrates config classes to@ConfigMapping
Migration of OIDC configuration classes to the
@ConfigMapping
is complicated because:@ConfigGroup
instances, we change values after runtime config setup has finished@ConfigGroup
as part of "public API" (meaning: they are in documentation, users directly produce instances of these classes and work with them)OidcTenantConfig
||OidcClientConfig
] ->OidcClientCommonConfig
->OidcCommonConfig
andOidcClientRegistrationConfig
->OidcCommonConfig
) shared by 3 extensionsThis PR introduces
@ConfigMapping
interfaces and makes original config classes POJOs.These POJOs are still used everywhere by Quarkus OIDC and users.
Regarding affected Quarkiverse extensions:
()
: