Fix missing version in extension

[cescoffier]

Issue reported in #441.
When the bom is present the version is not set in the pom.xml file.

[gsmet]

We can't parse the BOM somehow and check if the dependency is defined in the BOM?

[cescoffier]

Unfortunately not, it would require to compute the effective pom, which would be quite expensive. I agree it not a great solution, but this extension support is temporary anyway.

…

On Mon 7 Jan 2019 at 17:43, Guillaume Smet ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In maven/src/main/java/org/jboss/shamrock/maven/components/dependencies/Extensions.java <#442 (comment)> : > @@ -91,7 +92,7 @@ public static boolean addExtensions(Model model, List<String> extensions, Log lo if (!MojoUtils.hasDependency(model, optional.get().getGroupId(), optional.get().getArtifactId())) { log.info("Adding extension " + optional.get().toCoordinates()); - if (containsBOM(model)) { + if (containsBOM(model) && optional.get().getGroupId().startsWith(CreateProjectMojo.PLUGIN_GROUPID)) { We can't parse the BOM somehow and check if the dependency is defined in the BOM? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#442 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYjfUE5CudUe2P5f-W-4gI_OXg_LrqVks5vA3k3gaJpZM4Zz1iy> .

[cescoffier]

Once the dependency is added to the bon we just need to remove the hard coded version from the extension list. On Mon 7 Jan 2019 at 17:44, clement escoffier <clement.escoffier@gmail.com> wrote:

…

Unfortunately not, it would require to compute the effective pom, which would be quite expensive. I agree it not a great solution, but this extension support is temporary anyway. On Mon 7 Jan 2019 at 17:43, Guillaume Smet ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > maven/src/main/java/org/jboss/shamrock/maven/components/dependencies/Extensions.java > <#442 (comment)> > : > > > @@ -91,7 +92,7 @@ public static boolean addExtensions(Model model, List<String> extensions, Log lo > if (!MojoUtils.hasDependency(model, optional.get().getGroupId(), optional.get().getArtifactId())) { > log.info("Adding extension " + optional.get().toCoordinates()); > > - if (containsBOM(model)) { > + if (containsBOM(model) && optional.get().getGroupId().startsWith(CreateProjectMojo.PLUGIN_GROUPID)) { > > We can't parse the BOM somehow and check if the dependency is defined in > the BOM? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#442 (review)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAYjfUE5CudUe2P5f-W-4gI_OXg_LrqVks5vA3k3gaJpZM4Zz1iy> > . >

[cescoffier]

Actually there is a solution IF the bom does not use another bom. Let me try that On Mon 7 Jan 2019 at 17:45, clement escoffier <clement.escoffier@gmail.com> wrote:

…

Once the dependency is added to the bon we just need to remove the hard coded version from the extension list. On Mon 7 Jan 2019 at 17:44, clement escoffier ***@***.***> wrote: > Unfortunately not, it would require to compute the effective pom, which > would be quite expensive. > > I agree it not a great solution, but this extension support is temporary > anyway. > > On Mon 7 Jan 2019 at 17:43, Guillaume Smet ***@***.***> > wrote: > >> ***@***.**** commented on this pull request. >> ------------------------------ >> >> In >> maven/src/main/java/org/jboss/shamrock/maven/components/dependencies/Extensions.java >> <#442 (comment)> >> : >> >> > @@ -91,7 +92,7 @@ public static boolean addExtensions(Model model, List<String> extensions, Log lo >> if (!MojoUtils.hasDependency(model, optional.get().getGroupId(), optional.get().getArtifactId())) { >> log.info("Adding extension " + optional.get().toCoordinates()); >> >> - if (containsBOM(model)) { >> + if (containsBOM(model) && optional.get().getGroupId().startsWith(CreateProjectMojo.PLUGIN_GROUPID)) { >> >> We can't parse the BOM somehow and check if the dependency is defined in >> the BOM? >> >> — >> You are receiving this because you authored the thread. >> Reply to this email directly, view it on GitHub >> <#442 (review)>, >> or mute the thread >> <https://github.com/notifications/unsubscribe-auth/AAYjfUE5CudUe2P5f-W-4gI_OXg_LrqVks5vA3k3gaJpZM4Zz1iy> >> . >> >

[cescoffier]

@gsmet I've updated the PR to resolve the dependencies from the BOM and check whether the given extension is defined in the bom file.

[gsmet]

Looks good, thanks, merging!