Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify JFR configuration when using OTel Metrics #44286

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Nov 4, 2024

No description provided.

Copy link

github-actions bot commented Nov 4, 2024

🎊 PR Preview 4968e01 has been successfully built and deployed to https://quarkus-pr-main-44286-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link

quarkus-bot bot commented Nov 4, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 0083e0d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

This comment has been minimized.

@brunobat brunobat force-pushed the otel-native-metrics-jfr-docs branch from 03284f0 to b589e1c Compare November 13, 2024 12:16
Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @brunobat !

@brunobat brunobat force-pushed the otel-native-metrics-jfr-docs branch from b589e1c to fd94b0b Compare November 13, 2024 13:17

This comment has been minimized.

This comment has been minimized.

@brunobat brunobat force-pushed the otel-native-metrics-jfr-docs branch from e68390a to d0cdd27 Compare November 14, 2024 10:35
@brunobat
Copy link
Contributor Author

Fixed conflicts and rebased.

This comment has been minimized.

@brunobat brunobat force-pushed the otel-native-metrics-jfr-docs branch from d0cdd27 to 3a88f3d Compare November 18, 2024 09:05
Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

Copy link

quarkus-bot bot commented Nov 18, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 3a88f3d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@brunobat brunobat merged commit 1393d64 into quarkusio:main Nov 18, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 18, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.0 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants