Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support conditional dependencies on regular artifacts #44700

Merged

Conversation

aloubyansky
Copy link
Member

This change adds support for conditional dependencies on regular Maven artifacts, which is useful specifically in dev mode. The docs have been updated.

Basically, dev mode could be used as a condition to enable dependencies on regular Maven artifacts as well as other Quarkus extensions.

NOTE: this is still about Quarkus extensions declaring conditional dependencies, not applications.

FYI @phillip-kruger

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle labels Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Nov 25, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit aac0bdf.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@aloubyansky aloubyansky merged commit 6bf9d2b into quarkusio:main Nov 26, 2024
55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 26, 2024
@geoand
Copy link
Contributor

geoand commented Dec 2, 2024

cc @alesj @brunobat this should make possible to remove quarkus-observability-devservices-lgtm for users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants