Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default fan speed should be stored in EEPROM #189

Closed
ryan-summers opened this issue Feb 3, 2022 · 2 comments · Fixed by #216
Closed

Default fan speed should be stored in EEPROM #189

ryan-summers opened this issue Feb 3, 2022 · 2 comments · Fixed by #216
Milestone

Comments

@ryan-summers
Copy link
Member

ryan-summers commented Feb 3, 2022

The default fan speed should be saved somewhere. It's currently only stored via MQTT, but this feature may be desired for MQTT-less implementations.

@jordens jordens added this to the 0.4.0 milestone Feb 8, 2022
@ryan-summers
Copy link
Member Author

@jordens With the addition of fan speed stored in EEPROM and removal of gateway/ip/netmask, I was curious to hear your opinions on maintaining backward compatibility of settings with the NGFW.

Two main questions:

  • Do we want to "auto-upgrade" the settings when necessary (e.g. populate a default fan-speed) without throwing away previous configurations?
  • Do we want to ensure that settings remain in place such that if the user reverts to an older Booster release, the EEPROM settings will remain usable?

@jordens
Copy link
Member

jordens commented Apr 19, 2022

I would say yes to both. Unless there are problems like storage space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants