From d4426a90915ef5baa65ae99f2f7da0255ce25d4d Mon Sep 17 00:00:00 2001 From: Davis Vaughan Date: Wed, 30 Oct 2024 12:35:15 -0400 Subject: [PATCH 1/2] Don't minify during development --- apps/vscode/build.ts | 1 - packages/build/src/index.ts | 13 +++++-------- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/apps/vscode/build.ts b/apps/vscode/build.ts index e1010ae9..ad52272c 100644 --- a/apps/vscode/build.ts +++ b/apps/vscode/build.ts @@ -22,6 +22,5 @@ runBuild({ entryPoints: ['./src/main.ts'], outfile: './out/main.js', external: ['vscode'], - minify: dev, dev }); diff --git a/packages/build/src/index.ts b/packages/build/src/index.ts index 0381ee94..55eecaae 100644 --- a/packages/build/src/index.ts +++ b/packages/build/src/index.ts @@ -21,7 +21,6 @@ export interface BuildOptions { outfile: string; assets?: Array; bundle?: boolean; // true - minify?: boolean; // false format?: Format; // cjs platform?: Platform; // node external?: string[]; // [] @@ -36,25 +35,24 @@ export async function runBuild(options: BuildOptions) { bundle = true, format = 'cjs', platform = 'node', - minify = false, external, dev = false } = options; - await build({ + await build({ entryPoints, outfile, bundle, - minify, + minify: !dev, format, platform, external, sourcemap: dev, watch: dev ? { onRebuild(error) { - if (error) + if (error) console.error('[watch] build failed:', error) - else + else console.log('[watch] build finished') }, } : false, @@ -65,9 +63,8 @@ export async function runBuild(options: BuildOptions) { }), ] : [], }); - + if (dev) { console.log("[watch] build finished, watching for changes..."); } } - From 3c4324c9529635e74d8e4c9f5a1c5d03f8cac676 Mon Sep 17 00:00:00 2001 From: Davis Vaughan Date: Fri, 1 Nov 2024 10:50:21 -0400 Subject: [PATCH 2/2] Keep `minify` to make even more minimal fix --- apps/lsp/build.ts | 1 + apps/vscode/build.ts | 1 + packages/build/src/index.ts | 4 +++- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/apps/lsp/build.ts b/apps/lsp/build.ts index 79f26084..35bbbe52 100644 --- a/apps/lsp/build.ts +++ b/apps/lsp/build.ts @@ -30,5 +30,6 @@ runBuild({ { from: ['../../packages/editor-server/src/resources/**'], to: './dist/resources/' }, { from: ['../../packages/quarto-core/src/resources/**'], to: './dist/resources/' }, { from: ['./dist/**'], to: ['../vscode/out/lsp/'] }], + minify: !dev, dev }) diff --git a/apps/vscode/build.ts b/apps/vscode/build.ts index ad52272c..2acf06f9 100644 --- a/apps/vscode/build.ts +++ b/apps/vscode/build.ts @@ -22,5 +22,6 @@ runBuild({ entryPoints: ['./src/main.ts'], outfile: './out/main.js', external: ['vscode'], + minify: !dev, dev }); diff --git a/packages/build/src/index.ts b/packages/build/src/index.ts index 55eecaae..827d5fa6 100644 --- a/packages/build/src/index.ts +++ b/packages/build/src/index.ts @@ -21,6 +21,7 @@ export interface BuildOptions { outfile: string; assets?: Array; bundle?: boolean; // true + minify?: boolean; // false format?: Format; // cjs platform?: Platform; // node external?: string[]; // [] @@ -33,6 +34,7 @@ export async function runBuild(options: BuildOptions) { outfile, assets, bundle = true, + minify = false, format = 'cjs', platform = 'node', external, @@ -43,7 +45,7 @@ export async function runBuild(options: BuildOptions) { entryPoints, outfile, bundle, - minify: !dev, + minify, format, platform, external,