Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuartzInitializerListener: fix a typo #212

Closed
wants to merge 1 commit into from

Conversation

caladyon
Copy link

It seems that the shutdownWaitPref variable should be null-checked instead of shutdownPref variable, that was checked few rows before.

It seems that the shutdownWaitPref variable should be null-checked instead of shutdownPref variable, that was checked few rows before.
Copy link

@jarlah jarlah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you get to the conclusion, other than the obvious "read the code and spot the error"? The problem is, I cannot know if this is a bug or intentional without having a unit test or something to lean on?

zemian added a commit that referenced this pull request Feb 8, 2019
This fix is from PR #212 by @caladyon. Thank you for the contribution!
@zemian
Copy link
Contributor

zemian commented Feb 8, 2019

@caladyon Thank you for the fix! I have ported your change into a new PR ##322 against quartz-2.3.x branch instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants