Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup maven dependency tree #416

Closed
zemian opened this issue Apr 1, 2019 · 1 comment
Closed

Cleanup maven dependency tree #416

zemian opened this issue Apr 1, 2019 · 1 comment
Labels
in:build Quartz build system (Maven) stale Inactive items that will be automatically closed if not resurrected

Comments

@zemian
Copy link
Contributor

zemian commented Apr 1, 2019

Current Quartz Maven pom and modules setup is very confusing. It uses a internal groupId that's remapped during distribution into a single jar dependency into Maven central. It will be more clean if we simply use simple direct groupId and artifactId as intended without these odd repackage distribution logic. It makes build complex.

mvn dependency:tree
[INFO] org.quartz-scheduler:quartz:jar:2.4.0-SNAPSHOT
[INFO] +- org.quartz-scheduler.internal:quartz-terracotta-bootstrap:jar:2.4.0-SNAPSHOT:compile
[INFO] +- org.quartz-scheduler.internal:quartz-core:jar:2.4.0-SNAPSHOT:compile
[INFO] |  +- com.mchange:c3p0:jar:0.9.5.3:compile
[INFO] |  |  \- com.mchange:mchange-commons-java:jar:0.2.15:compile
[INFO] |  +- com.zaxxer:HikariCP:jar:3.2.0:compile
[INFO] |  \- org.slf4j:slf4j-api:jar:1.7.7:compile
[INFO] +- org.quartz-scheduler.internal:quartz-commonj:jar:2.4.0-SNAPSHOT:compile
[INFO] +- org.quartz-scheduler.internal:quartz-jboss:jar:2.4.0-SNAPSHOT:compile
[INFO] +- org.quartz-scheduler.internal:quartz-oracle:jar:2.4.0-SNAPSHOT:compile
[INFO] +- org.quartz-scheduler.internal:quartz-weblogic:jar:2.4.0-SNAPSHOT:compile
[INFO] +- org.quartz-scheduler.internal:quartz-plugins:jar:2.4.0-SNAPSHOT:compile
[INFO] +- org.quartz-scheduler:quartz-jobs:jar:2.4.0-SNAPSHOT:provided
[INFO] \- org.terracotta:product-upgradability-testing-utils:jar:0.9.0:test
[INFO]    +- org.terracotta.toolkit:terracotta-toolkit-api:jar:2.5:test
[INFO]    +- org.terracotta.toolkit:terracotta-toolkit-api-internal:jar:1.12:test
[INFO]    +- org.mockito:mockito-core:jar:1.9.5:test
[INFO]    |  \- org.objenesis:objenesis:jar:1.0:test
[INFO]    +- junit:junit:jar:4.11:test
[INFO]    +- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO]    \- org.hamcrest:hamcrest-library:jar:1.3:test

Suggested solution is simply make GAV like this:

org.quartz-scheduler:quartz:jar:2.4.0-SNAPSHOT:compile
  org.quartz-scheduler:quartz-jobs:jar:2.4.0-SNAPSHOT:compile
  org.quartz-scheduler:quartz-plugins:jar:2.4.0-SNAPSHOT:compile
org.slf4j:slf4j-api:jar:1.7.7:compile

All other modules should be optional.

@stale
Copy link

stale bot commented Aug 3, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Inactive items that will be automatically closed if not resurrected label Aug 3, 2021
@stale stale bot closed this as completed Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:build Quartz build system (Maven) stale Inactive items that will be automatically closed if not resurrected
Projects
None yet
Development

No branches or pull requests

1 participant