Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return at most maxCount triggers #490

Closed
wants to merge 1 commit into from
Closed

Return at most maxCount triggers #490

wants to merge 1 commit into from

Conversation

bradbeck
Copy link
Contributor

@bradbeck bradbeck commented Sep 12, 2019

Addresses Issue: #491

In cases where the JDBC driver does not respect PreparedStatement.setFetchSize and PreparedStatement.setMaxRows, the current logic may return more than maxCount results.

@chrisdennis
Copy link
Contributor

Good catch. I've taken the liberty of rebasing your fix against the earliest commit (daggy fix: https://wiki.monotone.ca/DaggyFixes/) and added a unit test. That work is under a new PR #499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants