vite-plugin incorrectly relies on vite mode

[yurks]

What happened?

vite build --mode qa (or any other mode except 'production') produces a bundle with development import of quasar.

What did you expect to happen?

Only vite command is used for development and running vite build command should produce production bundle for any mode:

Reproduction URL

https://github.com/yurks/quasar-vite-issue

How to reproduce?

1. fork provided repo
2. run yarn build to check correct production build
3. run yarn build:qa to check incorrect production qa build

Flavour

Vite Plugin (@quasar/vite-plugin)

Areas

Quasar CLI Commands/Configuration (@quasar/cli | @quasar/app-webpack | @quasar/app-vite)

Platforms/Browsers

No response

Quasar info output

No response

Relevant log output

No response

Additional context

Vite modes is a bit tricky and it's not always obvious that production mode is not the same with NODE_ENV=production. That means we can run vite build with different modes, but suppose to have production build as a result.

Quasars vite-plugin relies on vite mode here and here which makes impossible to have production build with vite build --mode qa, for example. It would be more correct to rely on build value of vite env config command property.

[rstoenescu]

Hi,

Vite command	viteConf.command	viteConf.mode
serve	serve	development
build	build	production
preview	serve	production

If not relying on "mode" then the "vite preview" command will confuse our plugin and produce a hybrid compilation (dev + prod parts combined).

[yurks]

@rstoenescu is this fixed somewhere?

// just commented in #17272

[rstoenescu]

Let's continue conversation on the PR. I have just noticed the comment there.