Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control over position of QCarousel quick-nav #1671

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

dsl101
Copy link
Contributor

@dsl101 dsl101 commented Feb 28, 2018

Add a prop to control whether the quick-nav is shown at the bottom (default) or top.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Add a prop to control whether the quick-nav is shown at the bottom (default) or top.
@rstoenescu
Copy link
Member

Merging it but will test later and change prop to quick-nav-position (top/bottom, default bottom) to allow further growth in the future

@rstoenescu rstoenescu merged commit 86886bc into quasarframework:dev Mar 2, 2018
@dsl101
Copy link
Contributor Author

dsl101 commented Mar 2, 2018 via email

@dsl101
Copy link
Contributor Author

dsl101 commented Mar 2, 2018

I'm also having to do some custom CSS in my app, as I don't want the qucknav to be on top of the content. So I was wondering about a prop quick-nav-overlay (true/false, default true) which would add some margin to the content area.

@dsl101 dsl101 deleted the patch-4 branch March 2, 2018 13:58
@rstoenescu
Copy link
Member

No, doing the mod myself. Don't want to actually bloat the component and start adding paddings and so on. This will be entirely up to developers in their websites/apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants